From: Willem de Bruijn <willemdebruijn.kernel@gmail•com>
To: Jakub Kicinski <kuba@kernel•org>, davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com,
andrew+netdev@lunn•ch, horms@kernel•org,
willemdebruijn.kernel@gmail•com,
Jakub Kicinski <kuba@kernel•org>
Subject: Re: [PATCH net-next 0/2] selftests: drv-net: so_txtime: trivial fixes
Date: Mon, 08 Jun 2026 16:21:39 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.753e66b6c929@gmail.com> (raw)
In-Reply-To: <20260608173305.372987-1-kuba@kernel.org>
Jakub Kicinski wrote:
> I noticed that so_txtime is only passing on NIPA setups which are
> looped within a single host. The cross-machine cases just flat out
> fail. The initial bug is obvious - the test does not deploy the binary.
> But even with that I think more work would be needed to sync the
> time / adjust the expectations for a dual-machine test.
>
> Feel free to nack / take over, this series is admittedly achieving
> very little in practice. The test will still not be usable on dual-host.
Thanks for these initial fixes.
I have indeed focused on vng and physical prod, where I cannot deploy
kselftests as is, run them a bit differently. And evidently missed
important parts as a result.
Let me spin up some cloud instances instead and iron out these kinks.
> Jakub Kicinski (2):
> selftests: drv-net: so_txtime: remember to deploy the binaries
> selftests: drv-net: so_txtime: check IP versions
>
> tools/testing/selftests/drivers/net/so_txtime.py | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> --
> 2.54.0
>
prev parent reply other threads:[~2026-06-08 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 17:33 [PATCH net-next 0/2] selftests: drv-net: so_txtime: trivial fixes Jakub Kicinski
2026-06-08 17:33 ` [PATCH net-next 1/2] selftests: drv-net: so_txtime: remember to deploy the binaries Jakub Kicinski
2026-06-08 20:21 ` Willem de Bruijn
2026-06-08 17:33 ` [PATCH net-next 2/2] selftests: drv-net: so_txtime: check IP versions Jakub Kicinski
2026-06-08 20:25 ` Willem de Bruijn
2026-06-08 21:39 ` Jakub Kicinski
2026-06-08 22:09 ` Willem de Bruijn
2026-06-08 20:21 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.753e66b6c929@gmail.com \
--to=willemdebruijn.kernel@gmail$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox