From: Willem de Bruijn <willemdebruijn.kernel@gmail•com>
To: Jakub Kicinski <kuba@kernel•org>, davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com,
andrew+netdev@lunn•ch, horms@kernel•org,
willemdebruijn.kernel@gmail•com,
Jakub Kicinski <kuba@kernel•org>
Subject: Re: [PATCH net-next 2/2] selftests: drv-net: so_txtime: check IP versions
Date: Mon, 08 Jun 2026 16:25:01 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.cc30d5c2f9ee@gmail.com> (raw)
In-Reply-To: <20260608173305.372987-3-kuba@kernel.org>
Jakub Kicinski wrote:
> This test needs more work, and it fails in non-obvious way
> when IPv4 connectivity is not available:
>
> # Exception| CMD[remote]: /tmp/vjquwblf/gukinuzqso_txtime -4 -c mono -t 1780939014114542914 -S None -D None a,0 -r
> # Exception| EXIT: -15
>
> Explicitly check for IPv4 support to make the future triage
> less painful.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
Reviewed-by: Willem de Bruijn <willemb@google•com>
but two comments FYI:
> ---
> tools/testing/selftests/drivers/net/so_txtime.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/so_txtime.py b/tools/testing/selftests/drivers/net/so_txtime.py
> index ddcd2c0e06a8..8fe061f52055 100755
> --- a/tools/testing/selftests/drivers/net/so_txtime.py
> +++ b/tools/testing/selftests/drivers/net/so_txtime.py
> @@ -64,6 +64,7 @@ from lib.py import NetDrvEpEnv, bkg, cmd, defer, tc
> @ksft_variants(_test_variants_mono())
> def test_so_txtime_mono(cfg, ipver, args_tx, args_rx):
> """Run all variants of monotonic (fq) tests."""
> + cfg.require_ipver(ipver)
This may cause aconflict with my outstanding SO_TXTIME series.
And more importantly miss having it in the new test_so_txtime_fq_tai
variant.
Could this test be moved to test_so_txtime that all of them call?
(there is WIP to add another mono_hw variant too)
> _qdisc_setup(cfg.ifname, "fq")
> test_so_txtime(cfg, "mono", ipver, args_tx, args_rx, True)
>
> @@ -86,6 +87,7 @@ from lib.py import NetDrvEpEnv, bkg, cmd, defer, tc
> @ksft_variants(_test_variants_etf())
> def test_so_txtime_etf(cfg, ipver, args_tx, args_rx, expect_fail):
> """Run all variants of etf tests."""
> + cfg.require_ipver(ipver)
> try:
> _qdisc_setup(cfg.ifname, "etf", "clockid CLOCK_TAI delta 400000")
> except Exception as e:
> --
> 2.54.0
>
next prev parent reply other threads:[~2026-06-08 20:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 17:33 [PATCH net-next 0/2] selftests: drv-net: so_txtime: trivial fixes Jakub Kicinski
2026-06-08 17:33 ` [PATCH net-next 1/2] selftests: drv-net: so_txtime: remember to deploy the binaries Jakub Kicinski
2026-06-08 20:21 ` Willem de Bruijn
2026-06-08 17:33 ` [PATCH net-next 2/2] selftests: drv-net: so_txtime: check IP versions Jakub Kicinski
2026-06-08 20:25 ` Willem de Bruijn [this message]
2026-06-08 21:39 ` Jakub Kicinski
2026-06-08 22:09 ` Willem de Bruijn
2026-06-08 20:21 ` [PATCH net-next 0/2] selftests: drv-net: so_txtime: trivial fixes Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.cc30d5c2f9ee@gmail.com \
--to=willemdebruijn.kernel@gmail$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox