From: Jes Sorensen <Jes.Sorensen@redhat•com>
To: Dave Jones <s.dave.jones@gmail•com>
Cc: Joe Perches <joe@perches•com>, John Heenan <john@zgus•com>,
Kalle Valo <kvalo@codeaurora•org>,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower
Date: Tue, 08 Nov 2016 09:29:07 -0500 [thread overview]
Message-ID: <wrfjh97i11vw.fsf@redhat.com> (raw)
In-Reply-To: <CANf5e8aQ+HZz47M3-4+qjsG=ZCaXhBFU_jVupLqT4rEYT2LQFQ@mail.gmail.com> (Dave Jones's message of "Tue, 8 Nov 2016 09:45:12 +0800")
Dave Jones <s.dave.jones@gmail•com> writes:
> On Fri, Nov 04, 2016 at 09:56:00AM -0400, Jes Sorensen wrote:
>>
>> Joe Perches <joe@perches•com> writes:
>> > On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote:
>> >> Code is 80 characters wide, and comments are /* */ never the ugly C++
>> >> crap.
>> >
>> > You might look at the recent Linus Torvalds authored commit
>> > 5e467652ffef (?printk: re-organize log_output() to be more legible")
>> > which does both of those: c99 // comments and > 80 columns.
>> >
>> > Absolutes are for zealots.
>>
>> What Linus does in his code, is totally up to him. What I pull into the
>> driver that *I* maintain, is up to me. It is perfectly normal to expect
>> submitters to respect the coding style of the piece of code they are
>> trying to edit.
>
> Bullshit. It's perfectly normal to respect Linux coding style described in
> Documentation/CodingStyle. Now let's back to the topic, could you
> apply John's patch or you just wanna improve your driver is 100% bug free?
First of all, I call for proper CodingStyle to be applied to my driver,
and I expect someone posting a patch to respect the codingstyle of the
driver in question. It is simple respect for the code. If you consider
that BS - that is on you!
Second I am NOT applying that patch as I have stated repeatedly because
I am not convinced it is safe to do so and it changes the code flow for
one type of chip and not the rest. In addition it uses a broken approach
to doing chip specific changes.
In short, the patch is broken!
Jes
next parent reply other threads:[~2016-11-10 15:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANf5e8aQ+HZz47M3-4+qjsG=ZCaXhBFU_jVupLqT4rEYT2LQFQ@mail.gmail.com>
2016-11-08 14:29 ` Jes Sorensen [this message]
[not found] ` <wrfjh97i11vw.fsf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-10 22:45 ` [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower Barry Day
[not found] <cover.1477769750.git.john@zgus.com>
2016-10-30 10:21 ` John Heenan
2016-10-30 12:00 ` Jes Sorensen
2016-10-30 13:56 ` John Heenan
2016-10-30 23:02 ` Jes Sorensen
2016-11-03 8:41 ` Joe Perches
2016-11-03 15:43 ` Larry Finger
[not found] ` <1478162497.1924.16.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-11-04 13:56 ` Jes Sorensen
2016-11-03 1:00 ` Larry Finger
2016-11-03 2:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjh97i11vw.fsf@redhat.com \
--to=jes.sorensen@redhat$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=john@zgus$(echo .)com \
--cc=kvalo@codeaurora$(echo .)org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=s.dave.jones@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox