Subject: Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable

From: Jes Sorensen <[email-masked]>
Date: Fri, 03 Jun 2016 15:31:03 -0400

Colin King <[email-masked]> writes:
> From: Colin Ian King <[email-masked]>
>
> path_b_ok is being assigned but immediately after path_a_ok is being
> compared to the value 0x03.  This appears to be a typo on the
> variable name, compare path_b_ok instead.
>
> Signed-off-by: Colin Ian King <[email-masked]>
> ---
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
> index fe19ace..b04cf30 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
> @@ -1149,7 +1149,7 @@ static void rtl8192eu_phy_iqcalibrate(struct rtl8xxxu_priv *priv,
>  
>  		for (i = 0; i < retry; i++) {
>  			path_b_ok = rtl8192eu_rx_iqk_path_b(priv);
> -			if (path_a_ok == 0x03) {
> +			if (path_b_ok == 0x03) {
>  				val32 = rtl8xxxu_read32(priv,
>  							REG_RX_POWER_BEFORE_IQK_B_2);
>  				result[t][6] = (val32 >> 16) & 0x3ff;

Nice catch, that does indeed look like a bug!

Thanks, I want to test it, but I plan to apply it to rtl8xxxu-devel
shortly.

Cheers,
Jes