From: Jes Sorensen <Jes.Sorensen@redhat•com>
To: Arnd Bergmann <arnd@arndb•de>
Cc: linux-wireless@vger•kernel.org,
"Kalle Valo" <kvalo@codeaurora•org>,
"Larry Finger" <Larry.Finger@lwfinger•net>,
netdev@vger•kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Raphaël Beamonte" <raphael.beamonte@gmail•com>,
devel@driverdev•osuosl.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 3/3] staging/rtl8192u: use s8 instead of char
Date: Tue, 19 Jul 2016 11:47:10 -0400 [thread overview]
Message-ID: <wrfjtwflvddt.fsf@redhat.com> (raw)
In-Reply-To: <20160719153403.2967812-3-arnd@arndb.de> (Arnd Bergmann's message of "Tue, 19 Jul 2016 17:33:02 +0200")
Arnd Bergmann <arnd@arndb•de> writes:
> Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of
> incorrect code that results from 'char' being unsigned here, e.g.
>
> staging/rtl8192u/r8192U_core.c:4150:16: error: comparison is always false due to limited range of data type [-Werror=type-limits]
> staging/rtl8192u/r8192U_dm.c:646:50: error: comparison is always false due to limited range of data type [-Werror=type-limits]
>
> This patch changes all uses of 'char' in this driver that refer to
> 8-bit integers to use 's8' instead, which is signed on all architectures.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 ++--
> drivers/staging/rtl8192u/r8192U.h | 4 ++--
> drivers/staging/rtl8192u/r8192U_core.c | 14 +++++++-------
> 3 files changed, 11 insertions(+), 11 deletions(-)
Looks good to me
Acked-by: Jes Sorensen <Jes.Sorensen@redhat•com>
next prev parent reply other threads:[~2016-07-19 15:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 15:33 [PATCH 1/3] rtlwifi: don't add include path for rtl8188ee Arnd Bergmann
2016-07-19 15:33 ` [PATCH 2/3] staging/rtl8192e: use s8 instead of char Arnd Bergmann
2016-07-19 15:46 ` Jes Sorensen
2016-07-19 15:53 ` Arnd Bergmann
2016-07-19 16:05 ` Jes Sorensen
[not found] ` <wrfjlh0xvck3.fsf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-20 8:25 ` Arnd Bergmann
2016-07-20 11:25 ` Jes Sorensen
[not found] ` <wrfjlh0wsg9s.fsf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-20 14:25 ` Larry Finger
2016-07-20 15:12 ` Arnd Bergmann
2016-07-20 15:33 ` Jes Sorensen
2016-07-20 16:00 ` Arnd Bergmann
2016-07-22 2:39 ` Stefan Lippers-Hollmann
2016-07-22 11:55 ` Jes Sorensen
2016-07-22 19:47 ` Arnd Bergmann
2016-07-22 20:51 ` Stefan Lippers-Hollmann
2016-07-19 15:33 ` [PATCH 3/3] staging/rtl8192u: " Arnd Bergmann
2016-07-19 15:47 ` Jes Sorensen [this message]
2016-07-19 18:17 ` [1/3] rtlwifi: don't add include path for rtl8188ee Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjtwflvddt.fsf@redhat.com \
--to=jes.sorensen@redhat$(echo .)com \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=arnd@arndb$(echo .)de \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=kvalo@codeaurora$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=raphael.beamonte@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox