From: Vlad Buslov <vladbu@nvidia•com>
To: Antoine Tenart <atenart@kernel•org>
Cc: <davem@davemloft•net>, <kuba@kernel•org>, <echaudro@redhat•com>,
<sbrivio@redhat•com>, <netdev@vger•kernel.org>, <pshelar@ovn•org>
Subject: Re: [PATCH net 1/2] vxlan: do not modify the shared tunnel info when PMTU triggers an ICMP reply
Date: Mon, 31 Jan 2022 19:55:44 +0200 [thread overview]
Message-ID: <ygnhiltzpz6n.fsf@nvidia.com> (raw)
In-Reply-To: <164363560725.4133.7633393991691247425@kwain>
On Mon 31 Jan 2022 at 15:26, Antoine Tenart <atenart@kernel•org> wrote:
> Quoting Vlad Buslov (2022-01-31 12:26:47)
>> On Fri 28 Jan 2022 at 19:01, Antoine Tenart <atenart@kernel•org> wrote:
>> >
>> > I finally had some time to look at this. Does the diff below fix your
>> > issue?
>>
>> Yes, with the patch applied I'm no longer able to reproduce memory leak.
>> Thanks for fixing this!
>
> Thanks for testing. I'll send a formal patch, can I add your Tested-by?
Sure!
Reported-by: Vlad Buslov <vladbu@nvidia•com>
Tested-by: Vlad Buslov <vladbu@nvidia•com>
>
> Also, do you know how to trigger the following code path in OVS
> https://elixir.bootlin.com/linux/latest/source/net/openvswitch/actions.c#L944
> ? Would be good (not required) to test it, to ensure the fix doesn't
> break it.
Sorry, I don't. We mostly concentrate on testing hardware
offload-specific code paths (e.g. TC).
>
> Thanks,
> Antoine
>
>> > diff --git a/include/net/dst_metadata.h b/include/net/dst_metadata.h
>> > index 14efa0ded75d..90a7a4daea9c 100644
>> > --- a/include/net/dst_metadata.h
>> > +++ b/include/net/dst_metadata.h
>> > @@ -110,8 +110,8 @@ static inline struct metadata_dst *tun_rx_dst(int md_size)
>> > static inline struct metadata_dst *tun_dst_unclone(struct sk_buff *skb)
>> > {
>> > struct metadata_dst *md_dst = skb_metadata_dst(skb);
>> > - int md_size;
>> > struct metadata_dst *new_md;
>> > + int md_size, ret;
>> >
>> > if (!md_dst || md_dst->type != METADATA_IP_TUNNEL)
>> > return ERR_PTR(-EINVAL);
>> > @@ -123,8 +123,15 @@ static inline struct metadata_dst *tun_dst_unclone(struct sk_buff *skb)
>> >
>> > memcpy(&new_md->u.tun_info, &md_dst->u.tun_info,
>> > sizeof(struct ip_tunnel_info) + md_size);
>> > +#ifdef CONFIG_DST_CACHE
>> > + ret = dst_cache_init(&new_md->u.tun_info.dst_cache, GFP_ATOMIC);
>> > + if (ret) {
>> > + metadata_dst_free(new_md);
>> > + return ERR_PTR(ret);
>> > + }
>> > +#endif
>> > +
>> > skb_dst_drop(skb);
>> > - dst_hold(&new_md->dst);
>> > skb_dst_set(skb, &new_md->dst);
>> > return new_md;
>> > }
next prev parent reply other threads:[~2022-01-31 17:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 15:35 [PATCH net 0/2] net: do not modify the shared tunnel info when PMTU triggers an ICMP reply Antoine Tenart
2021-03-25 15:35 ` [PATCH net 1/2] vxlan: " Antoine Tenart
2022-01-20 7:38 ` Vlad Buslov
2022-01-20 10:27 ` Antoine Tenart
2022-01-20 12:58 ` Vlad Buslov
2022-01-28 17:01 ` Antoine Tenart
2022-01-31 11:26 ` Vlad Buslov
2022-01-31 13:26 ` Antoine Tenart
2022-01-31 14:04 ` Stefano Brivio
2022-01-31 14:42 ` Antoine Tenart
2022-01-31 17:55 ` Vlad Buslov [this message]
2021-03-25 15:35 ` [PATCH net 2/2] geneve: " Antoine Tenart
2021-03-25 20:28 ` [PATCH net 0/2] net: " Stefano Brivio
2021-03-26 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ygnhiltzpz6n.fsf@nvidia.com \
--to=vladbu@nvidia$(echo .)com \
--cc=atenart@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=echaudro@redhat$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pshelar@ovn$(echo .)org \
--cc=sbrivio@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox