public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle•com>
To: Saurav Kashyap <skashyap@marvell•com>
Cc: <martin.petersen@oracle•com>,
	<GR-QLogic-Storage-Upstream@marvell•com>,
	<linux-scsi@vger•kernel.org>, <jhasan@marvell•com>,
	<netdev@vger•kernel.org>
Subject: Re: [PATCH v3 2/7] qedf: Fix for the deviations from the SAM-4 spec.
Date: Mon, 13 Apr 2020 21:22:49 -0400	[thread overview]
Message-ID: <yq13696vp1y.fsf@oracle.com> (raw)
In-Reply-To: <20200403120957.2431-3-skashyap@marvell.com> (Saurav Kashyap's message of "Fri, 3 Apr 2020 05:09:52 -0700")


Saurav,

This should be 3 patches since there are 3 different functional
changes.

> - Upper limit for retry delay(QEDF_RETRY_DELAY_MAX)
>   increased from 20 sec to 1 min.

> - Log an event/message indicating throttling of I/O
>   for the target and include scope and retry delay
>   time returned by the target and the driver enforced delay.

> - Synchronizing the update of the fcport->retry_delay_timestamp
>   between qedf_queuecommand() and qedf_scsi_completion().

"Synchronize".

Please describe why this needs to be synchronized.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2020-04-14  1:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03 12:09 [PATCH v3 0/7] qed/qedf: Firmware recovery, bw update and misc fixes Saurav Kashyap
2020-04-03 12:09 ` [PATCH v3 1/7] qedf: Keep track of num of pending flogi Saurav Kashyap
2020-04-14  1:19   ` Martin K. Petersen
2020-04-14  4:13     ` [EXT] " Saurav Kashyap
2020-04-03 12:09 ` [PATCH v3 2/7] qedf: Fix for the deviations from the SAM-4 spec Saurav Kashyap
2020-04-14  1:22   ` Martin K. Petersen [this message]
2020-04-14  4:20     ` [EXT] " Saurav Kashyap
2020-04-03 12:09 ` [PATCH v3 3/7] qed: Send BW update notifications to the protocol drivers Saurav Kashyap
2020-04-03 12:09 ` [PATCH v3 4/7] qedf: Implement callback for bw_update Saurav Kashyap
2020-04-14  1:24   ` Martin K. Petersen
2020-04-14  4:18     ` [EXT] " Saurav Kashyap
2020-04-03 12:09 ` [PATCH v3 5/7] qedf: Add schedule recovery handler Saurav Kashyap
2020-04-14  1:25   ` Martin K. Petersen
2020-04-03 12:09 ` [PATCH v3 6/7] qedf: Fix crash when MFW calls for protocol stats while function is still probing Saurav Kashyap
2020-04-03 12:09 ` [PATCH v3 7/7] qedf: Get dev info after updating the params Saurav Kashyap
2020-04-14  1:27   ` Martin K. Petersen
2020-04-14  4:21     ` [EXT] " Saurav Kashyap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq13696vp1y.fsf@oracle.com \
    --to=martin.petersen@oracle$(echo .)com \
    --cc=GR-QLogic-Storage-Upstream@marvell$(echo .)com \
    --cc=jhasan@marvell$(echo .)com \
    --cc=linux-scsi@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=skashyap@marvell$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox