From: "Martin K. Petersen" <martin.petersen@oracle•com>
To: Coly Li <colyli@suse•de>
Cc: linux-block@vger•kernel.org, linux-nvme@lists•infradead.org,
netdev@vger•kernel.org, open-iscsi@googlegroups•com,
linux-scsi@vger•kernel.org, ceph-devel@vger•kernel.org,
linux-kernel@vger•kernel.org, Vasily Averin <vvs@virtuozzo•com>,
Cong Wang <amwang@redhat•com>,
Mike Christie <michaelc@cs•wisc.edu>,
Lee Duncan <lduncan@suse•com>, Chris Leech <cleech@redhat•com>,
Christoph Hellwig <hch@lst•de>, Hannes Reinecke <hare@suse•de>
Subject: Re: [PATCH v8 6/7] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map()
Date: Fri, 25 Sep 2020 16:54:07 -0400 [thread overview]
Message-ID: <yq18scxinmw.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20200925150119.112016-7-colyli@suse.de> (Coly Li's message of "Fri, 25 Sep 2020 23:01:18 +0800")
Coly,
> In iscsci driver, iscsi_tcp_segment_map() uses the following code to
> check whether the page should or not be handled by sendpage:
> if (!recv && page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)))
>
> The "page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)" part is to
> make sure the page can be sent to network layer's zero copy path. This
> part is exactly what sendpage_ok() does.
>
> This patch uses use sendpage_ok() in iscsi_tcp_segment_map() to replace
> the original open coded checks.
Looks fine to me.
Acked-by: Martin K. Petersen <martin.petersen@oracle•com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-09-25 20:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 15:01 [PATCH v8 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers Coly Li
2020-09-25 15:01 ` [PATCH v8 1/7] net: introduce helper sendpage_ok() in include/linux/net.h Coly Li
2020-09-25 15:18 ` Greg KH
2020-09-26 13:28 ` Coly Li
2020-09-27 12:21 ` Greg KH
2020-09-25 15:01 ` [PATCH v8 2/7] net: add WARN_ONCE in kernel_sendpage() for improper zero-copy send Coly Li
2020-09-25 15:01 ` [PATCH v8 3/7] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage() Coly Li
2020-09-25 15:01 ` [PATCH v8 4/7] tcp: use sendpage_ok() to detect misused .sendpage Coly Li
2020-09-25 15:01 ` [PATCH v8 5/7] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage() Coly Li
2020-09-25 15:01 ` [PATCH v8 6/7] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map() Coly Li
2020-09-25 20:54 ` Martin K. Petersen [this message]
2020-09-25 15:01 ` [PATCH v8 7/7] libceph: use sendpage_ok() in ceph_tcp_sendpage() Coly Li
2020-09-25 15:13 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18scxinmw.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle$(echo .)com \
--cc=amwang@redhat$(echo .)com \
--cc=ceph-devel@vger$(echo .)kernel.org \
--cc=cleech@redhat$(echo .)com \
--cc=colyli@suse$(echo .)de \
--cc=hare@suse$(echo .)de \
--cc=hch@lst$(echo .)de \
--cc=lduncan@suse$(echo .)com \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nvme@lists$(echo .)infradead.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=michaelc@cs$(echo .)wisc.edu \
--cc=netdev@vger$(echo .)kernel.org \
--cc=open-iscsi@googlegroups$(echo .)com \
--cc=vvs@virtuozzo$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox