From: "Martin K. Petersen" <martin.petersen@oracle•com>
To: Arnd Bergmann <arnd@arndb•de>
Cc: Kees Cook <keescook@chromium•org>,
James Smart <james.smart@broadcom•com>,
Dick Kennedy <dick.kennedy@broadcom•com>,
"James E.J. Bottomley" <jejb@linux•ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
Larry Finger <Larry.Finger@lwfinger•net>,
Florian Schilhabel <florian.c.schilhabel@googlemail•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
"David S . Miller" <davem@davemloft•net>,
Wensong Zhang <wensong@linux-vs•org>,
Simon Horman <horms@verge•net.au>, Julian Anastasov <ja@ssi•bg>,
Pablo Neira Ayuso <pablo@netfilter•org>,
James Morris <jmorris@namei•org>,
linux-scsi@vger•kernel.org, linux-kernel@vger•kernel.org,
devel@driverdev•osuosl.org, netdev@vger•kernel.org,
lvs-devel@vger•kernel.org, netfilter-devel@vger•kernel.org,
coreteam@netfilter•org,
Ard Biesheuvel <ard.biesheuvel@linaro•org>,
Hannes Reinecke <hare@suse•com>, Willy Tarreau <w@1wt•eu>,
Silvio Cesare <silvio.cesare@gmail•com>
Subject: Re: [PATCH 2/4] lpfc: reduce stack size with CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE
Date: Thu, 11 Jul 2019 20:47:03 -0400 [thread overview]
Message-ID: <yq1y3146pvc.fsf@oracle.com> (raw)
In-Reply-To: <20190628123819.2785504-2-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 28 Jun 2019 14:37:47 +0200")
Arnd,
> The lpfc_debug_dump_all_queues() function repeatedly calls into
> lpfc_debug_dump_qe(), which has a temporary 128 byte buffer. This was
> fine before the introduction of CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE
> because each instance could occupy the same stack slot. However, now
> they each get their own copy, which leads to a huge increase in stack
> usage as seen from the compiler warning:
Applied to 5.3/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-07-12 0:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 12:37 [PATCH 1/4] [v2] structleak: disable STRUCTLEAK_BYREF in combination with KASAN_STACK Arnd Bergmann
2019-06-28 12:37 ` [PATCH 2/4] lpfc: reduce stack size with CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE Arnd Bergmann
2019-06-28 18:57 ` James Smart
2019-07-12 0:47 ` Martin K. Petersen [this message]
2019-06-28 12:37 ` [PATCH 3/4] staging: rtl8712: reduce stack usage, again Arnd Bergmann
2019-06-28 19:52 ` Willem de Bruijn
2019-06-28 12:37 ` [PATCH 4/4] ipvs: reduce kernel stack usage Arnd Bergmann
2019-06-28 19:50 ` Willem de Bruijn
2019-07-22 10:28 ` Arnd Bergmann
2019-06-30 20:36 ` Julian Anastasov
2019-07-22 10:16 ` Arnd Bergmann
2019-06-28 14:48 ` [PATCH 1/4] [v2] structleak: disable STRUCTLEAK_BYREF in combination with KASAN_STACK Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y3146pvc.fsf@oracle.com \
--to=martin.petersen@oracle$(echo .)com \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=coreteam@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=dick.kennedy@broadcom$(echo .)com \
--cc=florian.c.schilhabel@googlemail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hare@suse$(echo .)com \
--cc=horms@verge$(echo .)net.au \
--cc=ja@ssi$(echo .)bg \
--cc=james.smart@broadcom$(echo .)com \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jmorris@namei$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=lvs-devel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=silvio.cesare@gmail$(echo .)com \
--cc=w@1wt$(echo .)eu \
--cc=wensong@linux-vs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox