From: Xin Long <lucien.xin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: network dev <netdev@vger.kernel.org>,
quic@lists.linux.dev, davem@davemloft.net,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Stefan Metzmacher <metze@samba.org>,
Moritz Buhl <mbuhl@openbsd.org>,
Tyler Fanelli <tfanelli@redhat.com>,
Pengtao He <hepengtao@xiaomi.com>,
Thomas Dreibholz <dreibh@simula.no>,
linux-cifs@vger.kernel.org, Steve French <smfrench@gmail.com>,
Namjae Jeon <linkinjeon@kernel.org>,
Paulo Alcantara <pc@manguebit.com>, Tom Talpey <tom@talpey.com>,
kernel-tls-handshake@lists.linux.dev,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
Steve Dickson <steved@redhat.com>,
Hannes Reinecke <hare@suse.de>,
Alexander Aring <aahringo@redhat.com>,
David Howells <dhowells@redhat.com>,
Matthieu Baerts <matttbe@kernel.org>,
John Ericson <mail@johnericson.me>,
Cong Wang <xiyou.wangcong@gmail.com>,
"D . Wythe" <alibuda@linux.alibaba.com>,
Jason Baron <jbaron@akamai.com>,
illiliti <illiliti@protonmail.com>,
Sabrina Dubroca <sd@queasysnail.net>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Daniel Stenberg <daniel@haxx.se>,
Andy Gospodarek <andrew.gospodarek@broadcom.com>
Subject: Re: [PATCH net-next v5 00/16] net: introduce QUIC infrastructure and core subcomponents
Date: Fri, 28 Nov 2025 17:21:30 -0500 [thread overview]
Message-ID: <CADvbK_crxSB+TwDgEtjV6TUEeO9VYtsE6rqy7L_=rzoDrCfORQ@mail.gmail.com> (raw)
In-Reply-To: <20251127183008.5ee6757f@kernel.org>
On Thu, Nov 27, 2025 at 9:30 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 24 Nov 2025 09:28:13 -0500 Xin Long wrote:
> > The QUIC protocol, defined in RFC 9000, is a secure, multiplexed transport
> > built on top of UDP. It enables low-latency connection establishment,
> > stream-based communication with flow control, and supports connection
> > migration across network paths, while ensuring confidentiality, integrity,
> > and availability.
>
> Please look thru the Claude review and address the legit complaints:
>
> https://netdev-ai.bots.linux.dev/ai-review.html?id=8ac157b3-6222-4e89-ac52-28e4ca52d6c4
>
> If the tool is confused but not in an dumb way - it may be worth adding
> a relevant comment or info in the commit message. Otherwise a note under
> --- would be appreciated to avoid maintainers having to re-check the
> comments you already considered and disproved.
Thanks for the link.
I just went through the tool’s report. It found one real issue in
quic_packet_backlog_work(), which I’ll fix. The other items aren’t
actual problems, and I’ll add some inline comments or --- notes to
explain them.
>
> Thanks for adding the MAINTAINERS entry, two notes on that:
> - the entries must be sorted, so you need to move it down under Q
> instead of putting it next to SCTP
> - you seem to have copy/pasted the uAPI path for SCTP to the entry
> instead of QUIC ;)
You're right, thanks!
prev parent reply other threads:[~2025-11-28 22:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 14:28 [PATCH net-next v5 00/16] net: introduce QUIC infrastructure and core subcomponents Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 01/16] net: define IPPROTO_QUIC and SOL_QUIC constants Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 02/16] net: build socket infrastructure for QUIC protocol Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 03/16] quic: provide common utilities and data structures Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 04/16] quic: provide family ops for address and protocol Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 05/16] quic: provide quic.h header files for kernel and userspace Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 06/16] quic: add stream management Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 07/16] quic: add connection id management Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 08/16] quic: add path management Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 09/16] quic: add congestion control Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 10/16] quic: add packet number space Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 11/16] quic: add crypto key derivation and installation Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 12/16] quic: add crypto packet encryption and decryption Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 13/16] quic: add timer management Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 14/16] quic: add frame encoder and decoder base Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 15/16] quic: add packet builder base Xin Long
2025-11-24 14:28 ` [PATCH net-next v5 16/16] quic: add packet parser base Xin Long
2025-11-28 2:30 ` [PATCH net-next v5 00/16] net: introduce QUIC infrastructure and core subcomponents Jakub Kicinski
2025-11-28 22:21 ` Xin Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADvbK_crxSB+TwDgEtjV6TUEeO9VYtsE6rqy7L_=rzoDrCfORQ@mail.gmail.com' \
--to=lucien.xin@gmail.com \
--cc=aahringo@redhat.com \
--cc=alibuda@linux.alibaba.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=chuck.lever@oracle.com \
--cc=daniel@haxx.se \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dreibh@simula.no \
--cc=edumazet@google.com \
--cc=hare@suse.de \
--cc=hepengtao@xiaomi.com \
--cc=horms@kernel.org \
--cc=illiliti@protonmail.com \
--cc=jbaron@akamai.com \
--cc=jlayton@kernel.org \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=mail@johnericson.me \
--cc=marcelo.leitner@gmail.com \
--cc=matttbe@kernel.org \
--cc=mbuhl@openbsd.org \
--cc=metze@samba.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pc@manguebit.com \
--cc=quic@lists.linux.dev \
--cc=sd@queasysnail.net \
--cc=smfrench@gmail.com \
--cc=steved@redhat.com \
--cc=tfanelli@redhat.com \
--cc=tom@talpey.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox