From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C98AB274FF5 for ; Tue, 23 Sep 2025 17:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758648633; cv=none; b=XE/P8ADRkIN1KXAHsECwKZ91DVXMya4YpoqIJ8szJ84kfnVStwOBg9R93DIK3yTV56iQ93ugFxuAAO7+eaEaLtmW1zqR6dr8ZIYH1pVnMfx8T+MIjr5MsNZ6B9EKKdfHeVeWLLj1mutMtOHy5hEJabg79D/lW65QltCntVRL9nw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758648633; c=relaxed/simple; bh=hghWyqMLEkBfQ6eizevoRvpGAa/9gRmG+OWcHoOGofk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=UwWJhv8qr5P1dQab8llSKZkxdeXFAX447O8xYkWNZ6/onI7aFfU3/2a3TjmeJuq59G483g557078rwWwJ8XXJMD9v6qEZJXQuS3sl7NoiHbfZzsxjtzPpu0HNfQDXx8fOFCLfis8aO+J0P72m+/+8kh53KszTASWOeTf55U7imA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jMhFDABd; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jMhFDABd" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-b54a588ad96so96293a12.1 for ; Tue, 23 Sep 2025 10:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758648631; x=1759253431; darn=lists.linux.dev; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=otSvr9lp4hjuRht1Ui7CukSWsccNU1CrkcBBZa9JT28=; b=jMhFDABd8+FEhwzmrGEqWVe0ZNUNZub7GaofzJM5CK1Fhz09RAa6MJ6/kIKPCIZDBj crgzgLhwMG168Rvp7KRWbRNbWUudgt2g/dXv5FxLvnP+UQl5LiL9jqRDUCAt+kipfbkW VgeOdOZ4Rh83qKztU85t6Tq9zZLpZwnfcnUoBrWRkym1nG7zxuJDVi3pjQX+filRMtUc 8tcsKk2PKzgmyzMtAb+PI2nRkf/2sW3/tvQgWMKLSlC7GcA96jVlvBcyXVhGpKTWFzUQ UZyYjgLeVpcfzzAhVSrJqs5W7jwobM9qSECuW4uTyb5f6X875mkXqZAZH9Xx42WrZ7Il 0zDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758648631; x=1759253431; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=otSvr9lp4hjuRht1Ui7CukSWsccNU1CrkcBBZa9JT28=; b=VxiUhifbCbN4ajlq3w8NdJcDWedn9tnb14766JWG3830bS6od8gaQxesmZTfUAAJCC 9ex8RXhl6gVVz+osbWltsbsJmVQLNk8pL+jF5dbKjwomvudPYVgXg1VFHrz1H1RHu3cP g3jruTWxILFF0J0rBoVtw3YsAV5N0MohUJ3XgSh3A6W/t3G6r/FuJhBoReG8bPn+bPhY sP/HtfPOHxSN6S5+86VmQCREUE+Z+xN4NdArqMXGOuHpgBcAGUQiAfNnDFNc5BMPD6d+ zHXjpqW72rmTnfPBEy1ftFJdm3T6FAS2fpjvcHA1tTYuYC4K9m4yxJjFcObAkLc/t+JR VeFg== X-Forwarded-Encrypted: i=1; AJvYcCXYywjQVtH2PXYK6OTFB/NKv4cPLtgnnZ2N5WjUNkg9R8Ai5R0KYMRZB4qj6B/ESDPuqFCc@lists.linux.dev X-Gm-Message-State: AOJu0Yxy6vmLHjKGysr4TVhfzZ1ICsYbAuBqgq91z+uEAGPGKOcXqMYf x50l2Of7dExruddVdNI8z2sf6HrDwkAtrDk7d6VWtCD+xpXEKdCmDckaA0IaeRWWSHd9Y6oYOEE y9oOeJzQGZP1gZXU1v8EWAnanJyqxu3U= X-Gm-Gg: ASbGncuMrAQ2Rs940O+N3DbTvkdaqRA+5wafuoa9b4Y0UzexrPMuuF88zsmmlrS5aQi FDmGdD1kw1OC4PoHxhUU1rDYloAslH3k8vOUiGBrM7b1TdsyxzjuI+VpfgfKfHlixkfdJUMSRap L9WgjcQXUGCfeGjfN0AQQncH75A08n49yh9l9l+EiYc6Ida7L2A8Zv7gdysfgkHTNJTFZtWTFbM 2ww8DOLSg== X-Google-Smtp-Source: AGHT+IHb7FTPS0aqNTQzQxRJZ7PGJRzwxQRu5Dd0GpM/MUJTuLqqFTKwQpdKNuhZ2pSdZPeFP657nduMMphE8QtkB48= X-Received: by 2002:a17:902:fc8d:b0:26b:3cb5:a906 with SMTP id d9443c01a7336-27cdaa73d2amr41672395ad.16.1758648631008; Tue, 23 Sep 2025 10:30:31 -0700 (PDT) Precedence: bulk X-Mailing-List: quic@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <5d71a793a5f6e85160748ed30539b98d2629c5ac.1758234904.git.lucien.xin@gmail.com> <20250923090951.GF836419@horms.kernel.org> In-Reply-To: <20250923090951.GF836419@horms.kernel.org> From: Xin Long Date: Tue, 23 Sep 2025 13:30:19 -0400 X-Gm-Features: AS18NWC9LYwbDwlF4C91L7kgoi_08hlFtRBrmqddeIKr75MWVxTZmLpz7q1S7tQ Message-ID: Subject: Re: [PATCH net-next v3 06/15] quic: add stream management To: Simon Horman Cc: network dev , quic@lists.linux.dev, davem@davemloft.net, kuba@kernel.org, Eric Dumazet , Paolo Abeni , Stefan Metzmacher , Moritz Buhl , Tyler Fanelli , Pengtao He , linux-cifs@vger.kernel.org, Steve French , Namjae Jeon , Paulo Alcantara , Tom Talpey , kernel-tls-handshake@lists.linux.dev, Chuck Lever , Jeff Layton , Benjamin Coddington , Steve Dickson , Hannes Reinecke , Alexander Aring , David Howells , Matthieu Baerts , John Ericson , Cong Wang , "D . Wythe" , Jason Baron , illiliti , Sabrina Dubroca , Marcelo Ricardo Leitner , Daniel Stenberg , Andy Gospodarek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 23, 2025 at 5:09=E2=80=AFAM Simon Horman wro= te: > > On Thu, Sep 18, 2025 at 06:34:55PM -0400, Xin Long wrote: > > ... > > > diff --git a/net/quic/stream.c b/net/quic/stream.c > > ... > > > +/* Create and register new streams for sending. */ > > +static struct quic_stream *quic_stream_send_create(struct quic_stream_= table *streams, > > + s64 max_stream_id, u8 = is_serv) > > +{ > > + struct quic_stream *stream; > > + s64 stream_id; > > + > > + stream_id =3D streams->send.next_bidi_stream_id; > > + if (quic_stream_id_uni(max_stream_id)) > > + stream_id =3D streams->send.next_uni_stream_id; > > + > > + /* rfc9000#section-2.1: A stream ID that is used out of order res= ults in all streams > > + * of that type with lower-numbered stream IDs also being opened. > > + */ > > + while (stream_id <=3D max_stream_id) { > > + stream =3D kzalloc(sizeof(*stream), GFP_KERNEL); > > + if (!stream) > > + return NULL; > > ... > > > + } > > + return stream; > > Hi Xin, > > I'm unsure if can happen - actually I doubt it can - but > if the loop above iterates zero times then stream will be used > uninitialised here. This can't happen. But it's better to initialize it to NULL. Othersize, it always looks like a potential issue. Thanks. > > Likewise in quic_stream_recv_create(). > > Flagged by Smatch > > ...