From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C53892566D9 for ; Thu, 6 Nov 2025 16:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762447264; cv=none; b=Sw1u5o6w2YBHeuYmnYHI7Che8UYiigEHGU6EavmyMrqqPNSH6vqK2thRr90Hg6wmG2i0OECguzELjjKdAgNgXjPRaMFErBNdTRAQ0qAarN/QWUvsGO0JtKt2qRHbzc/xcKwUVUpnjG0APzWWtJyBMSjImUKxLJ2P8rpOh3G2UYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762447264; c=relaxed/simple; bh=TBcIWrbd4TaZLgB/ZJb6p325CdBt3uGaZyZ9kmR9+1c=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=KUxqoVId9CVJGCkK56KFRYdD1Tvovyf9dmieGcic6cGLsJ7qfZryXqHXEEbo/O/b0WJxvfi/qcpaHOV6bc2K+CBYx7hnY9gxaBOiHXFLxvCd34Bf6EfL/lVO0/SyskEvRl37dEnl0rfG6EDv6n8RPqpZ7spZbMDiaTJtCHVkOog= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OHvrxYH7; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OHvrxYH7" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-341c68c953bso1586242a91.1 for ; Thu, 06 Nov 2025 08:41:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762447261; x=1763052061; darn=lists.linux.dev; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mvC8dwzzaWG4yq5+kQqkL0SJpAh/HOeEJ2LSeIlJuUc=; b=OHvrxYH71Q+UsYMqPTIJigBz3X0u4bh0ZbFiC9y4RPIgfddJGmpgWgjLkvLOgd3/PS 3ZFX8YXOkAwY9iiX7JQj/kSsG0VhrR3GChsbjTt2TkOUdgR/BgJiuOyToFd4o3HpqD/T mFAcEsYg/EDmBubynRvDcEKGo5USRjaYtzm4Np9pJP67ub78iGoLOOLTdSZlCZr5aeOA 7SEJ58p/CDYqDKbNRsLz8/SaNDMzu6IuHBAxVbpXnfRYMOzFwdya8W6h1S56IL0arsyX M6k7Kkl7ol6K3HUggt9v+DvWdOxm3zKOehK8O3qsHr4DRi/fvkE1wl1hgghZhfNyQRin 99uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762447261; x=1763052061; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvC8dwzzaWG4yq5+kQqkL0SJpAh/HOeEJ2LSeIlJuUc=; b=MugxpE3n3oUxrvjMlH+b10CoeWcsU0hMjPX/DzGv8bJgmLUagjc2WGZqB4vUfVhF9+ Zdx8Q4IWdKjYdPWG1grW+dCxwCIHX6uPT6s4UZfY/5E9IlM15O5JWZFrWNAu22iAWKpz Hd3T65qzmzXe5M+M+YZhEDTEk/ZyURsHf54rujfGSWwhsB9Fmn6p3lxJJDqfQKYQl/+J tOId/v8SiBgwOnXXu7/hB5nFYLR/+w5rIXUfzKQcItj8Tqe/BjA1WkYAYkEjP0WdXY7Y ByCFFBLKnpTSixdxMCGPT0wkmbV7ScGyjAzqX7fyJclqWMre5ivJs7v7/HarQl3U5M3o DGsw== X-Forwarded-Encrypted: i=1; AJvYcCUVpjuL+grx9CxgZau2SfBvH7NxcjkWST2ivxD3nB7/g1ZCLqtaXdzu6UJ/4UmBxBS1YtcK@lists.linux.dev X-Gm-Message-State: AOJu0Yz10QZhORdw7RkeHhYnjOBiZg8lZ6ERFniMN6gjh/zAlHd4T57t W4i2PPNVizTqV/JoCgVh9JUum0aIa37GPIA5n9D2s/qZRngDHFvijO7X6+szL1EFw5ad4+JeZAP 6SVtxZ2QzazwOe+iH1eWqEvebZ9NvbHI= X-Gm-Gg: ASbGncu6JHrOyqH3TWT5YmLguqu7+Kx+k7DpDFmYvf+/ieStBp+6D8r31Lujyp1Gzw7 gKBcGCMLOEw3oHWxV9cr8g8dsmqYXO8H/mctCGz6t8P2Zl1zxTk3dypP9dO6hxrIVMxg+7vLEli 4zRqCmr35go+1cHHmhtmdY8y9qnZSGxNysC3fykh3eQp6ysy4BxumDxVSvjYMPOahG97cijPPMZ uMaIma6DkXAXc5OcNGmFsfC9QQeRFeslFk5F3m+r43/yslvgLWnOaV3r1dclBQK2O/CFQQ6Sy70 1s8yOSPTydMvkxH4cB8= X-Google-Smtp-Source: AGHT+IFhNfCSdGalSOf406WxoKMEjh2ITqWtl6zazWFVAs7ueoni8JgesPYbjGRu4NLpQW9g3l96QGzY8CifeXnMhgQ= X-Received: by 2002:a17:90b:2888:b0:341:8bda:d0ae with SMTP id 98e67ed59e1d1-341a6dd83b4mr10067477a91.20.1762447260941; Thu, 06 Nov 2025 08:41:00 -0800 (PST) Precedence: bulk X-Mailing-List: quic@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <635b0dad-98bf-41e9-b7b6-1f28da48fc00@redhat.com> In-Reply-To: <635b0dad-98bf-41e9-b7b6-1f28da48fc00@redhat.com> From: Xin Long Date: Thu, 6 Nov 2025 11:40:49 -0500 X-Gm-Features: AWmQ_bly4E8gAJHH1RdZ4TnHldWIBRhfNNyves1f0Q8O3wlRAgOEjU9eQ8XrsCA Message-ID: Subject: Re: [PATCH net-next v4 10/15] quic: add packet number space To: Paolo Abeni Cc: network dev , quic@lists.linux.dev, davem@davemloft.net, kuba@kernel.org, Eric Dumazet , Simon Horman , Stefan Metzmacher , Moritz Buhl , Tyler Fanelli , Pengtao He , Thomas Dreibholz , linux-cifs@vger.kernel.org, Steve French , Namjae Jeon , Paulo Alcantara , Tom Talpey , kernel-tls-handshake@lists.linux.dev, Chuck Lever , Jeff Layton , Benjamin Coddington , Steve Dickson , Hannes Reinecke , Alexander Aring , David Howells , Matthieu Baerts , John Ericson , Cong Wang , "D . Wythe" , Jason Baron , illiliti , Sabrina Dubroca , Marcelo Ricardo Leitner , Daniel Stenberg , Andy Gospodarek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 4, 2025 at 7:17=E2=80=AFAM Paolo Abeni wrot= e: > > On 10/29/25 3:35 PM, Xin Long wrote: > > +struct quic_pnspace { > > + /* ECN counters indexed by direction (TX/RX) and ECN codepoint (E= CT1, ECT0, CE) */ > > + u64 ecn_count[QUIC_ECN_DIR_MAX][QUIC_ECN_MAX]; > > + unsigned long *pn_map; /* Bit map tracking received packet numbe= rs for ACK generation */ > > + u16 pn_map_len; /* Length of the packet number bit map (i= n bits) */ > > + u8 need_sack:1; /* Flag indicating a SACK frame should be= sent for this space */ > > + u8 sack_path:1; /* Path used for sending the SACK frame *= / > > + > > + s64 last_max_pn_seen; /* Highest packet number seen before pn_m= ap advanced */ > > + u32 last_max_pn_time; /* Timestamp when last_max_pn_seen was re= ceived */ > > + u32 max_time_limit; /* Time threshold to trigger pn_map advan= cement on packet receipt */ > > + s64 min_pn_seen; /* Smallest packet number received in thi= s space */ > > + s64 max_pn_seen; /* Largest packet number received in this= space */ > > + u32 max_pn_time; /* Time at which max_pn_seen was received= */ > > + s64 base_pn; /* Packet number corresponding to the sta= rt of the pn_map */ > > + u32 time; /* Cached current time, or time accept a = socket (listen socket) */ > > There are a few 32 bits holes above you could avoid reordering the fields= . I will switch base_pn and time. For the hole after sack_path, It can't be avoided in this struct, I will leave it there. Thanks. > > Otherwise LGTM, > > Acked-by: Paolo Abeni >