From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7306B33F8DA for ; Thu, 29 Jan 2026 16:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769705603; cv=none; b=q1pG0kbOjzpwvOsrXcBLer7LhqwRDWkSVZ6OZxgMoP374HKktt+WD3q/0/nnAnAFm/AoBY4c4l9KaqJHtDoXxK+KuanAEMxGWtJx2TSizFyn8RA337wSHk3w3GN5HD8cYa6X8lrHNdyDdxmU+sfSTNiZEWn2JLFb/u9iXMs0uIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769705603; c=relaxed/simple; bh=WOGhGhsnQIX0JLxRhL6uuprL7CVf0Nxffn2Etmsupas=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pjOQ3KBZlv1EASe2xkla6vmC8ztt7KdOZA6hwYdLo7o05R15S/omFrsHAgrRoVhvPug6oxQRBtLvGl9SP3MJG8hwHf+MTedvODAXL218JI7jhGFFa+PIUfMur5sliRNLeWxTO2HPMM9PES6U8RbxT+lc32Y36j7F9J+0Yn+keSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FzwuvNBN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FzwuvNBN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769705601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bxsJZ4lY7/i7NTzxVza1t8bxhbR1O4VQ7g3k6JdX5O0=; b=FzwuvNBNkqnk9SyHXPyHb2M+FqkJV8Xpbb78Gynildhk9o6i6BFqWkYi9OkoxBR96fDITe k/E/j8flWnJu+fHSTFBpWyzjjqtnS06tgUiiZbPAXjIphX375H+oSFuciQg3XnWv8hXA3r 1cERL4tp3ipOrLtFH3+9MHXMeHFrEzA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-173-RCeZQxo4PuG8Y8ElPW1nNA-1; Thu, 29 Jan 2026 11:53:20 -0500 X-MC-Unique: RCeZQxo4PuG8Y8ElPW1nNA-1 X-Mimecast-MFC-AGG-ID: RCeZQxo4PuG8Y8ElPW1nNA_1769705599 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4359d70faa2so688428f8f.1 for ; Thu, 29 Jan 2026 08:53:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769705599; x=1770310399; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bxsJZ4lY7/i7NTzxVza1t8bxhbR1O4VQ7g3k6JdX5O0=; b=dJer1kUBFMTCBsxacGD92sX0+65hLz2b1D5FGKzGLEMyef4T2zNG7Ht+Y7H/koV9wR 55GVsLU6aok4SjraGdb7REgyYUf20q74sH/NiukQ1bSBTvStZKIywPjT7jh7z3K/kpC4 ILWala3K1Zr/73bETVq5U0dDHRV62UV3OTQD+gpvrLXkqx22U2FHe33g5bph52oUes88 36QMSa3vMdjYBgygyMsrCC1+CsqwQL0TIOXk9jp1j6BG2cd8SxaVZ4u/cjqeEgi+5uq1 IreZaENy4Iwybr6utZ1Y0LQgUbRZc87C9Pu4I5Wqf5L6as60sR9Gz96DkCUfJ4euxwag ++BQ== X-Forwarded-Encrypted: i=1; AJvYcCVdRSNjKNeKbs3X9ZmldXiAR/dF0MMci2j/5lnvcL1o+gB2i7/3xKVt+Qi/36ikaG/KYz+5@lists.linux.dev X-Gm-Message-State: AOJu0YwIj2tWlJxcUfzMS+BIfqmvchp0hEZlGyoP6c84wt8Oj5skXnOL m+wmLBT9eQn6UNpFmcJUuTnddkymYqLA9CEs4j7J54xQIBqru+VpxQbM2oCW/rMhkj/83zKbca6 Va95SXDqUEyldCgXuTEyqsNb6fAl1jrLcv2/IQUUP4cxDLT4ehyx2mmJz4WIjtnU= X-Gm-Gg: AZuq6aLyplRcEgZSpLo9UARm0TFYJwqqvJB8t6kQqWrjGTGEsKtGAxvsfRnezxxuhqA YpaesTF3ZZu8FoVtQM8tPtDNm048EzDTM5NkRHiTLFiZQhCKq/k6s1VIYi0uWQkY1L+DP8k9MRA MVD8ygSuxkNVUH/cjQ/3xIdAFHoK1N+NPgf9CKplNAkrpw1C5oTxNE9QsPMHzEcuQXu7hzyeksa XmPBEtQUg2dtPrYjkrnA/JDhCIOGoyGt0UtlP+BJVtD/1vbqV5VIxNLllxZaAsI/EqYCkKRMUcL TqlVnWWc+4DFdyqWOl2WBsZI0iSY62CSpUuM2HYVsFOJKQnEI4WtAnV1qO2HkJUpht19EN2myrK yvEJPfqn7vRVt X-Received: by 2002:a05:600c:4e90:b0:477:582e:7a81 with SMTP id 5b1f17b1804b1-48069c2a907mr105133575e9.4.1769705598731; Thu, 29 Jan 2026 08:53:18 -0800 (PST) X-Received: by 2002:a05:600c:4e90:b0:477:582e:7a81 with SMTP id 5b1f17b1804b1-48069c2a907mr105133265e9.4.1769705598230; Thu, 29 Jan 2026 08:53:18 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.56]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-481a5e195ecsm793975e9.4.2026.01.29.08.53.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 08:53:17 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 17:53:14 +0100 Precedence: bulk X-Mailing-List: quic@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v8 15/15] quic: add packet parser base To: Xin Long , network dev , quic@lists.linux.dev Cc: davem@davemloft.net, kuba@kernel.org, Eric Dumazet , Simon Horman , Stefan Metzmacher , Moritz Buhl , Tyler Fanelli , Pengtao He , Thomas Dreibholz , linux-cifs@vger.kernel.org, Steve French , Namjae Jeon , Paulo Alcantara , Tom Talpey , kernel-tls-handshake@lists.linux.dev, Chuck Lever , Jeff Layton , Steve Dickson , Hannes Reinecke , Alexander Aring , David Howells , Matthieu Baerts , John Ericson , Cong Wang , "D . Wythe" , Jason Baron , illiliti , Sabrina Dubroca , Marcelo Ricardo Leitner , Daniel Stenberg , Andy Gospodarek References: <46f93cbee41da1e1f7b7f408b17915fd93b39ec1.1769439073.git.lucien.xin@gmail.com> From: Paolo Abeni In-Reply-To: <46f93cbee41da1e1f7b7f408b17915fd93b39ec1.1769439073.git.lucien.xin@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hxMjKJt8FdVdtsRSPGGEhAMZ2C7ZrqaPWJ9V1T5Bo0Q_1769705599 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/26/26 3:51 PM, Xin Long wrote: > +/* Lookup listening socket for Client Initial packet (in process context). */ > +static struct sock *quic_packet_get_listen_sock(struct sk_buff *skb) > +{ > + union quic_addr daddr, saddr; > + struct quic_data alpns = {}; > + struct sock *sk; > + > + quic_get_msg_addrs(skb, &daddr, &saddr); > + > + if (quic_packet_parse_alpn(skb, &alpns)) > + return NULL; > + > + local_bh_disable(); Is this really needed? If so, it needs some comment explaining the rationale, otherwise please drop it. /P