From: Aaron Tomlin <atomlin@atomlin•com>
To: axboe@kernel•dk, kbusch@kernel•org, hch@lst•de, sagi@grimberg•me,
mst@redhat•com
Cc: atomlin@atomlin•com, aacraid@microsemi•com,
James.Bottomley@HansenPartnership•com,
martin.petersen@oracle•com, liyihang9@h-partners•com,
kashyap.desai@broadcom•com, sumit.saxena@broadcom•com,
shivasharan.srikanteshwara@broadcom•com,
chandrakanth.patil@broadcom•com, sathya.prakash@broadcom•com,
sreekanth.reddy@broadcom•com,
suganath-prabu.subramani@broadcom•com, ranjan.kumar@broadcom•com,
jinpu.wang@cloud•ionos.com, tglx@kernel•org, mingo@redhat•com,
peterz@infradead•org, juri.lelli@redhat•com,
vincent.guittot@linaro•org, akpm@linux-foundation•org,
maz@kernel•org, ruanjinjie@huawei•com, bigeasy@linutronix•de,
yphbchou0911@gmail•com, wagi@kernel•org, frederic@kernel•org,
longman@redhat•com, chenridong@huawei•com, hare@suse•de,
kch@nvidia•com, ming.lei@redhat•com, steve@abita•co,
sean@ashe•io, chjohnst@gmail•com, neelx@suse•com,
mproche@gmail•com, linux-block@vger•kernel.org,
linux-kernel@vger•kernel.org, virtualization@lists•linux.dev,
linux-nvme@lists•infradead.org, linux-scsi@vger•kernel.org,
megaraidlinux.pdl@broadcom•com, mpi3mr-linuxdrv.pdl@broadcom•com,
MPT-FusionLinux.pdl@broadcom•com
Subject: [PATCH v9 08/13] virtio: blk/scsi: use block layer helpers to constrain queue affinity
Date: Mon, 30 Mar 2026 18:10:42 -0400 [thread overview]
Message-ID: <20260330221047.630206-9-atomlin@atomlin.com> (raw)
In-Reply-To: <20260330221047.630206-1-atomlin@atomlin.com>
From: Daniel Wagner <wagi@kernel•org>
Ensure that IRQ affinity setup also respects the queue-to-CPU mapping
constraints provided by the block layer. This allows the virtio drivers
to avoid assigning interrupts to CPUs that the block layer has excluded
(e.g., isolated CPUs).
Reviewed-by: Hannes Reinecke <hare@suse•de>
Signed-off-by: Daniel Wagner <wagi@kernel•org>
---
drivers/block/virtio_blk.c | 4 +++-
drivers/scsi/virtio_scsi.c | 5 ++++-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index b1c9a27fe00f..9d737510454b 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -964,7 +964,9 @@ static int init_vq(struct virtio_blk *vblk)
unsigned short num_vqs;
unsigned short num_poll_vqs;
struct virtio_device *vdev = vblk->vdev;
- struct irq_affinity desc = { 0, };
+ struct irq_affinity desc = {
+ .mask = blk_mq_possible_queue_affinity(),
+ };
err = virtio_cread_feature(vdev, VIRTIO_BLK_F_MQ,
struct virtio_blk_config, num_queues,
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 0ed8558dad72..520a7da5386e 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -849,7 +849,10 @@ static int virtscsi_init(struct virtio_device *vdev,
u32 num_vqs, num_poll_vqs, num_req_vqs;
struct virtqueue_info *vqs_info;
struct virtqueue **vqs;
- struct irq_affinity desc = { .pre_vectors = 2 };
+ struct irq_affinity desc = {
+ .pre_vectors = 2,
+ .mask = blk_mq_possible_queue_affinity(),
+ };
num_req_vqs = vscsi->num_queues;
num_vqs = num_req_vqs + VIRTIO_SCSI_VQ_BASE;
--
2.51.0
next prev parent reply other threads:[~2026-03-30 22:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 22:10 [PATCH v9 00/13] blk: honor isolcpus configuration Aaron Tomlin
2026-03-30 22:10 ` [PATCH v9 01/13] scsi: aacraid: use block layer helpers to calculate num of queues Aaron Tomlin
2026-03-30 22:10 ` [PATCH v9 02/13] lib/group_cpus: remove dead !SMP code Aaron Tomlin
2026-04-01 12:29 ` Sebastian Andrzej Siewior
2026-04-01 19:31 ` Aaron Tomlin
2026-03-30 22:10 ` [PATCH v9 03/13] lib/group_cpus: Add group_mask_cpus_evenly() Aaron Tomlin
2026-03-30 22:10 ` [PATCH v9 04/13] genirq/affinity: Add cpumask to struct irq_affinity Aaron Tomlin
2026-03-30 22:10 ` [PATCH v9 05/13] blk-mq: add blk_mq_{online|possible}_queue_affinity Aaron Tomlin
2026-03-30 22:10 ` [PATCH v9 06/13] nvme-pci: use block layer helpers to constrain queue affinity Aaron Tomlin
2026-03-30 22:10 ` [PATCH v9 07/13] scsi: Use " Aaron Tomlin
2026-03-30 22:10 ` Aaron Tomlin [this message]
2026-03-30 22:10 ` [PATCH v9 09/13] isolation: Introduce io_queue isolcpus type Aaron Tomlin
2026-04-01 12:49 ` Sebastian Andrzej Siewior
2026-04-01 19:05 ` Waiman Long
2026-04-02 7:58 ` Sebastian Andrzej Siewior
2026-04-03 1:54 ` Waiman Long
2026-04-01 20:58 ` Aaron Tomlin
2026-04-02 9:09 ` Sebastian Andrzej Siewior
2026-04-03 0:50 ` Aaron Tomlin
2026-04-03 1:20 ` Ming Lei
2026-03-30 22:10 ` [PATCH v9 10/13] blk-mq: use hk cpus only when isolcpus=io_queue is enabled Aaron Tomlin
2026-03-31 23:05 ` Keith Busch
2026-04-01 17:16 ` Aaron Tomlin
2026-04-03 1:43 ` Ming Lei
2026-03-30 22:10 ` [PATCH v9 11/13] blk-mq: prevent offlining hk CPUs with associated online isolated CPUs Aaron Tomlin
2026-03-30 22:10 ` [PATCH v9 12/13] genirq/affinity: Restrict managed IRQ affinity to housekeeping CPUs Aaron Tomlin
2026-03-30 22:10 ` [PATCH v9 13/13] docs: add io_queue flag to isolcpus Aaron Tomlin
2026-03-31 1:01 ` [PATCH v9 00/13] blk: honor isolcpus configuration Ming Lei
2026-03-31 13:38 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330221047.630206-9-atomlin@atomlin.com \
--to=atomlin@atomlin$(echo .)com \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=MPT-FusionLinux.pdl@broadcom$(echo .)com \
--cc=aacraid@microsemi$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=axboe@kernel$(echo .)dk \
--cc=bigeasy@linutronix$(echo .)de \
--cc=chandrakanth.patil@broadcom$(echo .)com \
--cc=chenridong@huawei$(echo .)com \
--cc=chjohnst@gmail$(echo .)com \
--cc=frederic@kernel$(echo .)org \
--cc=hare@suse$(echo .)de \
--cc=hch@lst$(echo .)de \
--cc=jinpu.wang@cloud$(echo .)ionos.com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=kashyap.desai@broadcom$(echo .)com \
--cc=kbusch@kernel$(echo .)org \
--cc=kch@nvidia$(echo .)com \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nvme@lists$(echo .)infradead.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=liyihang9@h-partners$(echo .)com \
--cc=longman@redhat$(echo .)com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=megaraidlinux.pdl@broadcom$(echo .)com \
--cc=ming.lei@redhat$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=mpi3mr-linuxdrv.pdl@broadcom$(echo .)com \
--cc=mproche@gmail$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=neelx@suse$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=ranjan.kumar@broadcom$(echo .)com \
--cc=ruanjinjie@huawei$(echo .)com \
--cc=sagi@grimberg$(echo .)me \
--cc=sathya.prakash@broadcom$(echo .)com \
--cc=sean@ashe$(echo .)io \
--cc=shivasharan.srikanteshwara@broadcom$(echo .)com \
--cc=sreekanth.reddy@broadcom$(echo .)com \
--cc=steve@abita$(echo .)co \
--cc=suganath-prabu.subramani@broadcom$(echo .)com \
--cc=sumit.saxena@broadcom$(echo .)com \
--cc=tglx@kernel$(echo .)org \
--cc=vincent.guittot@linaro$(echo .)org \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=wagi@kernel$(echo .)org \
--cc=yphbchou0911@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox