From: Lorenzo Stoakes <ljs@kernel•org>
To: "Michael S. Tsirkin" <mst@redhat•com>
Cc: linux-kernel@vger•kernel.org,
"David Hildenbrand (Arm)" <david@kernel•org>,
"Jason Wang" <jasowang@redhat•com>,
"Xuan Zhuo" <xuanzhuo@linux•alibaba.com>,
"Eugenio Pérez" <eperezma@redhat•com>,
"Muchun Song" <muchun.song@linux•dev>,
"Oscar Salvador" <osalvador@suse•de>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Liam R. Howlett" <liam@infradead•org>,
"Vlastimil Babka" <vbabka@kernel•org>,
"Mike Rapoport" <rppt@kernel•org>,
"Suren Baghdasaryan" <surenb@google•com>,
"Michal Hocko" <mhocko@suse•com>,
"Brendan Jackman" <jackmanb@google•com>,
"Johannes Weiner" <hannes@cmpxchg•org>, "Zi Yan" <ziy@nvidia•com>,
"Baolin Wang" <baolin.wang@linux•alibaba.com>,
"Nico Pache" <npache@redhat•com>,
"Ryan Roberts" <ryan.roberts@arm•com>,
"Dev Jain" <dev.jain@arm•com>, "Barry Song" <baohua@kernel•org>,
"Lance Yang" <lance.yang@linux•dev>,
"Hugh Dickins" <hughd@google•com>,
"Matthew Brost" <matthew.brost@intel•com>,
"Joshua Hahn" <joshua.hahnjy@gmail•com>,
"Rakie Kim" <rakie.kim@sk•com>,
"Byungchul Park" <byungchul@sk•com>,
"Gregory Price" <gourry@gourry•net>,
"Ying Huang" <ying.huang@linux•alibaba.com>,
"Alistair Popple" <apopple@nvidia•com>,
"Christoph Lameter" <cl@gentwo•org>,
"David Rientjes" <rientjes@google•com>,
"Roman Gushchin" <roman.gushchin@linux•dev>,
"Harry Yoo" <harry.yoo@oracle•com>,
"Axel Rasmussen" <axelrasmussen@google•com>,
"Yuanchu Xie" <yuanchu@google•com>, "Wei Xu" <weixugc@google•com>,
"Chris Li" <chrisl@kernel•org>,
"Kairui Song" <kasong@tencent•com>,
"Kemeng Shi" <shikemeng@huaweicloud•com>,
"Nhat Pham" <nphamcs@gmail•com>, "Baoquan He" <bhe@redhat•com>,
virtualization@lists•linux.dev, linux-mm@kvack•org,
"Andrea Arcangeli" <aarcange@redhat•com>
Subject: Re: [PATCH v10 05/37] mm: hugetlb: remove dead alloc_hugetlb_folio stub
Date: Mon, 8 Jun 2026 10:56:48 +0100 [thread overview]
Message-ID: <aiaQ_I2kxfC2hVsD@lucifer> (raw)
In-Reply-To: <a9b5764c69269e5c0518e496b057a75354373b43.1780906288.git.mst@redhat.com>
On Mon, Jun 08, 2026 at 04:34:57AM -0400, Michael S. Tsirkin wrote:
> Remove the !CONFIG_HUGETLB_PAGE stub for alloc_hugetlb_folio().
>
> The stub is dead code: all callers are in mm/hugetlb.c
> (CONFIG_HUGETLB_PAGE) or fs/hugetlbfs/inode.c (CONFIG_HUGETLBFS),
obj-$(CONFIG_HUGETLBFS) += hugetlb.o hugetlb_sysfs.o hugetlb_sysctl.o
mm/hugetlb.c seems dependent on CONFIG_HUGETLBFS not CONFIG_HUGETLB_PAGE?
> and CONFIG_HUGETLB_PAGE is def_bool HUGETLBFS with nothing
> selecting it independently.
>
> The stub is also broken: it returns NULL, but all callers check
> IS_ERR(folio), so a NULL return would not be caught and would
> crash on the subsequent folio dereference.
>
> Remove it now since follow-up patches change the signature of
> alloc_hugetlb_folio and would otherwise need to update the
> broken stub too.
>
> Reviewed-by: Gregory Price <gourry@gourry•net>
> Assisted-by: Claude:claude-opus-4-6
> Reviewed-by: Dev Jain <dev.jain@arm•com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat•com>
The logic seems good but you should fix up the commit message. With that
fixed:
Reviewed-by: Lorenzo Stoakes <ljs@kernel•org>
Thanks, Lorenzo
> ---
> include/linux/hugetlb.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 5957bc25efa8..1f7ae6609e51 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -1123,13 +1123,6 @@ static inline void wait_for_freed_hugetlb_folios(void)
> {
> }
>
> -static inline struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma,
> - unsigned long addr,
> - bool cow_from_owner)
> -{
> - return NULL;
> -}
> -
> static inline struct folio *
> alloc_hugetlb_folio_reserve(struct hstate *h, int preferred_nid,
> nodemask_t *nmask, gfp_t gfp_mask)
> --
> MST
>
next prev parent reply other threads:[~2026-06-08 9:57 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 8:33 [PATCH v10 00/37] mm/virtio: skip redundant zeroing of host-zeroed pages Michael S. Tsirkin
2026-06-08 8:34 ` [PATCH v10 01/37] mm: mempolicy: fix interleave index calculation Michael S. Tsirkin
2026-06-08 9:43 ` Lorenzo Stoakes
2026-06-08 8:34 ` [PATCH v10 02/37] mm: memory-failure: serialize TestSetPageHWPoison with zone->lock Michael S. Tsirkin
2026-06-08 9:43 ` Lorenzo Stoakes
2026-06-08 8:34 ` [PATCH v10 03/37] mm: page_alloc: propagate PageReported flag across buddy splits Michael S. Tsirkin
2026-06-08 9:52 ` Lorenzo Stoakes
2026-06-08 12:50 ` Matthew Wilcox
2026-06-08 8:34 ` [PATCH v10 04/37] mm: page_reporting: allow driver to set batch capacity Michael S. Tsirkin
2026-06-08 8:34 ` [PATCH v10 05/37] mm: hugetlb: remove dead alloc_hugetlb_folio stub Michael S. Tsirkin
2026-06-08 9:56 ` Lorenzo Stoakes [this message]
2026-06-08 8:35 ` [PATCH v10 06/37] mm: move vma_alloc_folio_noprof to page_alloc.c Michael S. Tsirkin
2026-06-08 10:05 ` Lorenzo Stoakes
2026-06-08 8:35 ` [PATCH v10 07/37] mm: thread user_addr through page allocator for cache-friendly zeroing Michael S. Tsirkin
2026-06-08 10:23 ` Lorenzo Stoakes
2026-06-08 11:06 ` Lorenzo Stoakes
2026-06-08 13:04 ` Matthew Wilcox
2026-06-08 13:09 ` Lorenzo Stoakes
2026-06-08 11:08 ` David Hildenbrand (Arm)
2026-06-08 8:35 ` [PATCH v10 08/37] mm: add alloc_contig_frozen_pages_user " Michael S. Tsirkin
2026-06-08 10:29 ` Lorenzo Stoakes
2026-06-08 8:35 ` [PATCH v10 09/37] mm: hugetlb: thread user_addr through gigantic page allocation Michael S. Tsirkin
2026-06-08 8:36 ` [PATCH v10 10/37] mm: add folio_zero_user stub for configs without THP/HUGETLBFS Michael S. Tsirkin
2026-06-08 9:12 ` Lorenzo Stoakes
2026-06-08 8:36 ` [PATCH v10 11/37] mm: page_alloc: move prep_compound_page before post_alloc_hook Michael S. Tsirkin
2026-06-08 10:33 ` Lorenzo Stoakes
2026-06-08 8:36 ` [PATCH v10 12/37] mm: use folio_zero_user for user pages in post_alloc_hook Michael S. Tsirkin
2026-06-08 11:23 ` Lorenzo Stoakes
2026-06-08 8:36 ` [PATCH v10 13/37] mm: use __GFP_ZERO in vma_alloc_zeroed_movable_folio Michael S. Tsirkin
2026-06-08 10:39 ` Lorenzo Stoakes
2026-06-08 10:55 ` Lorenzo Stoakes
2026-06-08 8:37 ` [PATCH v10 14/37] mm: remove arch vma_alloc_zeroed_movable_folio overrides Michael S. Tsirkin
2026-06-08 11:29 ` Lorenzo Stoakes
2026-06-08 8:37 ` [PATCH v10 15/37] mm: alloc_anon_folio: pass raw fault address to vma_alloc_folio Michael S. Tsirkin
2026-06-08 11:35 ` Lorenzo Stoakes
2026-06-08 8:37 ` [PATCH v10 16/37] mm: alloc_swap_folio: " Michael S. Tsirkin
2026-06-08 11:37 ` Lorenzo Stoakes
2026-06-08 8:37 ` [PATCH v10 17/37] mm: page_reporting: skip redundant zeroing of host-zeroed reported pages Michael S. Tsirkin
2026-06-08 12:00 ` Lorenzo Stoakes
2026-06-08 8:38 ` [PATCH v10 18/37] mm: page_alloc: use aliasing checks instead of user_alloc_needs_zeroing Michael S. Tsirkin
2026-06-08 11:39 ` Lorenzo Stoakes
2026-06-08 8:38 ` [PATCH v10 19/37] mm: page_alloc: clear PG_zeroed on buddy merge if not both zero Michael S. Tsirkin
2026-06-08 11:47 ` Lorenzo Stoakes
2026-06-08 8:38 ` [PATCH v10 20/37] mm: page_alloc: preserve PG_zeroed in page_del_and_expand Michael S. Tsirkin
2026-06-08 8:38 ` [PATCH v10 21/37] mm: page_alloc: propagate PG_zeroed in split_large_buddy Michael S. Tsirkin
2026-06-08 8:38 ` [PATCH v10 22/37] mm: add free_frozen_pages_zeroed Michael S. Tsirkin
2026-06-08 12:06 ` Lorenzo Stoakes
2026-06-08 8:38 ` [PATCH v10 23/37] mm: page_alloc: skip kernel_init_pages for FPI_ZEROED when safe Michael S. Tsirkin
2026-06-08 12:18 ` Lorenzo Stoakes
2026-06-08 8:38 ` [PATCH v10 24/37] mm: add put_page_zeroed and folio_put_zeroed Michael S. Tsirkin
2026-06-08 12:25 ` Lorenzo Stoakes
2026-06-08 12:46 ` David Hildenbrand (Arm)
2026-06-08 8:39 ` [PATCH v10 25/37] mm: use __GFP_ZERO in alloc_anon_folio Michael S. Tsirkin
2026-06-08 12:29 ` Lorenzo Stoakes
2026-06-08 8:39 ` [PATCH v10 26/37] mm: vma_alloc_anon_folio_pmd: pass raw fault address to vma_alloc_folio Michael S. Tsirkin
2026-06-08 12:30 ` Lorenzo Stoakes
2026-06-08 8:39 ` [PATCH v10 27/37] mm: use __GFP_ZERO in vma_alloc_anon_folio_pmd Michael S. Tsirkin
2026-06-08 12:32 ` Lorenzo Stoakes
2026-06-08 8:39 ` [PATCH v10 28/37] mm: hugetlb: add gfp parameter and skip zeroing for zeroed pages Michael S. Tsirkin
2026-06-08 12:44 ` Lorenzo Stoakes
2026-06-08 8:39 ` [PATCH v10 29/37] mm: memfd: skip zeroing for zeroed hugetlb pool pages Michael S. Tsirkin
2026-06-08 12:47 ` Lorenzo Stoakes
2026-06-08 8:39 ` [PATCH v10 30/37] mm: page_reporting: add per-page zeroed bitmap for host feedback Michael S. Tsirkin
2026-06-08 8:39 ` [PATCH v10 31/37] virtio_balloon: submit reported pages as individual buffers Michael S. Tsirkin
2026-06-08 8:40 ` [PATCH v10 32/37] virtio_balloon: disable indirect descriptors Michael S. Tsirkin
2026-06-08 8:40 ` [PATCH v10 33/37] mm: page_reporting: add flush parameter with page budget Michael S. Tsirkin
2026-06-08 8:40 ` [PATCH v10 34/37] virtio_balloon: skip zeroing for host-zeroed reported pages Michael S. Tsirkin
2026-06-08 8:40 ` [PATCH v10 35/37] virtio_balloon: disable reporting zeroed optimization for confidential guests Michael S. Tsirkin
2026-06-08 8:40 ` [PATCH v10 36/37] mm: balloon: use put_page_zeroed for zeroed balloon pages Michael S. Tsirkin
2026-06-08 11:10 ` David Hildenbrand (Arm)
2026-06-08 8:40 ` [PATCH v10 37/37] virtio_balloon: implement VIRTIO_BALLOON_F_DEVICE_INIT_ON_INFLATE Michael S. Tsirkin
2026-06-08 9:17 ` [PATCH v10 00/37] mm/virtio: skip redundant zeroing of host-zeroed pages Lorenzo Stoakes
2026-06-08 12:52 ` Lorenzo Stoakes
2026-06-08 11:02 ` Vlastimil Babka (SUSE)
2026-06-08 11:13 ` Vlastimil Babka (SUSE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiaQ_I2kxfC2hVsD@lucifer \
--to=ljs@kernel$(echo .)org \
--cc=aarcange@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=apopple@nvidia$(echo .)com \
--cc=axelrasmussen@google$(echo .)com \
--cc=baohua@kernel$(echo .)org \
--cc=baolin.wang@linux$(echo .)alibaba.com \
--cc=bhe@redhat$(echo .)com \
--cc=byungchul@sk$(echo .)com \
--cc=chrisl@kernel$(echo .)org \
--cc=cl@gentwo$(echo .)org \
--cc=david@kernel$(echo .)org \
--cc=dev.jain@arm$(echo .)com \
--cc=eperezma@redhat$(echo .)com \
--cc=gourry@gourry$(echo .)net \
--cc=hannes@cmpxchg$(echo .)org \
--cc=harry.yoo@oracle$(echo .)com \
--cc=hughd@google$(echo .)com \
--cc=jackmanb@google$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=joshua.hahnjy@gmail$(echo .)com \
--cc=kasong@tencent$(echo .)com \
--cc=lance.yang@linux$(echo .)dev \
--cc=liam@infradead$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=matthew.brost@intel$(echo .)com \
--cc=mhocko@suse$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=muchun.song@linux$(echo .)dev \
--cc=npache@redhat$(echo .)com \
--cc=nphamcs@gmail$(echo .)com \
--cc=osalvador@suse$(echo .)de \
--cc=rakie.kim@sk$(echo .)com \
--cc=rientjes@google$(echo .)com \
--cc=roman.gushchin@linux$(echo .)dev \
--cc=rppt@kernel$(echo .)org \
--cc=ryan.roberts@arm$(echo .)com \
--cc=shikemeng@huaweicloud$(echo .)com \
--cc=surenb@google$(echo .)com \
--cc=vbabka@kernel$(echo .)org \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=weixugc@google$(echo .)com \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
--cc=ying.huang@linux$(echo .)alibaba.com \
--cc=yuanchu@google$(echo .)com \
--cc=ziy@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox