From: "René Scharfe" <l.s.r@web•de>
To: Junio C Hamano <gitster@pobox•com>
Cc: Git List <git@vger•kernel.org>
Subject: Re: [PATCH 2/2] add-patch: quit on EOF
Date: Sun, 26 Oct 2025 17:11:04 +0100 [thread overview]
Message-ID: <01fb6bdc-7a42-4e14-b7c7-16860ce8af00@web.de> (raw)
In-Reply-To: <xmqqfrb6mqv4.fsf@gitster.g>
On 10/26/25 2:46 AM, Junio C Hamano wrote:
>
> Let's do this squashed in.
>
> t/t3701-add-interactive.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git c/t/t3701-add-interactive.sh w/t/t3701-add-interactive.sh
> index 071b78c355..4285314f35 100755
> --- c/t/t3701-add-interactive.sh
> +++ w/t/t3701-add-interactive.sh
> @@ -1438,8 +1438,8 @@ test_expect_success 'EOF quits' '
> echo X >file &&
> echo X >file2 &&
> git add -p </dev/null >out &&
> - grep file out &&
> - ! grep file2 out
> + test_grep file out &&
> + test_grep ! file2 out
> '
>
> test_done
Good idea, thank you!
René
next prev parent reply other threads:[~2025-10-26 16:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-25 5:46 [PATCH 1/2] add-patch: quit without skipping undecided hunks René Scharfe
2025-10-25 5:48 ` [PATCH 2/2] add-patch: quit on EOF René Scharfe
2025-10-25 16:20 ` Junio C Hamano
2025-10-25 17:23 ` René Scharfe
2025-10-26 0:37 ` Junio C Hamano
2025-10-26 0:46 ` Junio C Hamano
2025-10-26 16:11 ` René Scharfe [this message]
2025-10-25 15:42 ` [PATCH 1/2] add-patch: quit without skipping undecided hunks Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01fb6bdc-7a42-4e14-b7c7-16860ce8af00@web.de \
--to=l.s.r@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox