From: "René Scharfe" <l.s.r@web•de>
To: Junio C Hamano <gitster@pobox•com>
Cc: Git List <git@vger•kernel.org>
Subject: Re: [PATCH 2/2] add-patch: quit on EOF
Date: Sat, 25 Oct 2025 19:23:26 +0200 [thread overview]
Message-ID: <06b8485e-1e64-4c57-be3a-34b1f900c526@web.de> (raw)
In-Reply-To: <xmqqfrb7nebp.fsf@gitster.g>
On 10/25/25 6:20 PM, Junio C Hamano wrote:
>
> I wonder if we want to 'echo" something in this case, though. If I
> say 'q', whether interactive.singlekey is active or not, I see
>
> (1/1) Stage this hunk [y,n,q,a,d,s,e,p,P,?]? q
>
> on the last line before getting the shell prompt back. With this
> change, I won't see anything after the prompt. Perhaps it is OK? I
> dunno. Perhaps we want to pretend as if 'q' were given instead of
> EOF, like the following? I dunno.
I'm used to no feedback when writing to a file using cat and finishing
with ctrl-D to signal end-of-file. So I don't need a q "echoed", and
would actually be slightly surprised. But that's just me.
René
next prev parent reply other threads:[~2025-10-25 17:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-25 5:46 [PATCH 1/2] add-patch: quit without skipping undecided hunks René Scharfe
2025-10-25 5:48 ` [PATCH 2/2] add-patch: quit on EOF René Scharfe
2025-10-25 16:20 ` Junio C Hamano
2025-10-25 17:23 ` René Scharfe [this message]
2025-10-26 0:37 ` Junio C Hamano
2025-10-26 0:46 ` Junio C Hamano
2025-10-26 16:11 ` René Scharfe
2025-10-25 15:42 ` [PATCH 1/2] add-patch: quit without skipping undecided hunks Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06b8485e-1e64-4c57-be3a-34b1f900c526@web.de \
--to=l.s.r@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox