public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Colin Stagner <ask+git@howdoi•land>
To: Junio C Hamano <gitster@pobox•com>
Cc: Ian Jackson <ijackson@chiark•greenend.org.uk>,
	git@vger•kernel.org, Christian Heusel <christian@heusel•eu>,
	george@mail•dietrich.pub, Christian Hesse <list@eworm•de>,
	Phillip Wood <phillip.wood@dunelm•org.uk>
Subject: Re: [PATCH v2 0/3] contrib/subtree: reduce recursion during split
Date: Tue, 2 Jun 2026 20:37:16 -0500	[thread overview]
Message-ID: <0915b5cc-5cbb-4cce-a832-147f85d4ff1f@howdoi.land> (raw)
In-Reply-To: <xmqqv7c13o5l.fsf@gitster.g>

On 6/1/26 17:13, Junio C Hamano wrote:

> I am tempted to mark the topic as stalled, to be discarded for
> inaction

No objection. I'd still like to see this reviewed, but we can revisit 
this later if interest develops.

> While I do agree that avoiding bash-isms in the main part of Git and
> sticking to vanilla POSIX has merit, this particular one seems more
> like an artificial limit imposed by dash than sticking to the POSIX
> as the common denoninator, at least to me.

Correct, this topic is a workaround for an artificial limit. The limit 
is Debian-specific and was introduced as a downstream patch in 2018 [1], 
[2].

This git-subtree issue has been reported before in

   <CAN7rbOve-EFOGPjr1wrD77r-3RQ+3+qso82_oV5Qud-skobL7w@mail•gmail.com>,

   <26263.63341.878041.155047@chiark•greenend.org.uk>,

and probably other places. These are old reports, and I haven't found 
anyone there still interested in a fix.



Colin


[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=579815

[2]: 
https://sources.debian.org/patches/dash/0.5.12-12/0009-dash-Fix-stack-overflow-from-infinite-recursion-in-s.patch/


  parent reply	other threads:[~2026-06-03  1:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-15 20:17 [PATCH 0/3] contrib/subtree: reduce recursion during split Colin Stagner
2026-02-15 20:17 ` [PATCH 1/3] contrib/subtree: reduce function side-effects Colin Stagner
2026-02-15 20:17 ` [PATCH 2/3] contrib/subtree: functionalize split traversal Colin Stagner
2026-02-15 20:17 ` [PATCH 3/3] contrib/subtree: reduce recursion during split Colin Stagner
2026-03-05 23:55 ` [PATCH v2 0/3] " Colin Stagner
2026-03-05 23:55   ` [PATCH v2 1/3] contrib/subtree: reduce function side-effects Colin Stagner
2026-03-05 23:55   ` [PATCH v2 2/3] contrib/subtree: functionalize split traversal Colin Stagner
2026-03-05 23:55   ` [PATCH v2 3/3] contrib/subtree: reduce recursion during split Colin Stagner
2026-03-13 22:51   ` [PATCH v2 0/3] " Junio C Hamano
2026-03-13 23:06     ` Junio C Hamano
2026-04-15 17:58       ` Junio C Hamano
2026-04-15 21:39         ` Ben Knoble
2026-04-16 13:25   ` Ian Jackson
2026-04-16 19:34     ` Junio C Hamano
2026-04-17  4:50     ` Colin Stagner
2026-04-19 19:55       ` Ian Jackson
2026-04-20  1:09         ` Ben Knoble
2026-04-20  1:50         ` Junio C Hamano
2026-04-20  9:57         ` Ian Jackson
2026-04-21  5:07           ` Colin Stagner
2026-04-22  9:43             ` Johannes Schindelin
2026-04-22 17:12           ` git-subtree rewrite Ian Jackson
2026-06-01 22:13       ` [PATCH v2 0/3] contrib/subtree: reduce recursion during split Junio C Hamano
2026-06-02  9:06         ` Ian Jackson
2026-06-03  1:37         ` Colin Stagner [this message]
2026-06-03  9:12           ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0915b5cc-5cbb-4cce-a832-147f85d4ff1f@howdoi.land \
    --to=ask+git@howdoi$(echo .)land \
    --cc=christian@heusel$(echo .)eu \
    --cc=george@mail$(echo .)dietrich.pub \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=ijackson@chiark$(echo .)greenend.org.uk \
    --cc=list@eworm$(echo .)de \
    --cc=phillip.wood@dunelm$(echo .)org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox