From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Toon Claes" <toon@iotcl•com>, git@vger•kernel.org
Cc: Gusted <gusted@codeberg•org>
Subject: Re: [PATCH v3 4/4] last-modified: change default max-depth to 0
Date: Sun, 25 Jan 2026 12:24:54 +0100 [thread overview]
Message-ID: <0b97e8fd-1dfc-4a38-9c77-22467f38fd3b@app.fastmail.com> (raw)
In-Reply-To: <20260120-toon-last-modified-zzzz-v3-4-9bffd4968b0e@iotcl.com>
On Tue, Jan 20, 2026, at 22:47, Toon Claes wrote:
> By default git-last-modified(1) doesn't recurse into subtrees. So when
> the pathspec contained a path in a subtree, the command would only print
> the commit information about the parent tree of the path, like:
>
> $ git last-modified -- path/file
> aaa0aab1bbb2bcc3ccc4ddd5dde6eee7eff8fff9 path
>
> Change the default behavior to give commit information about the exact
> path instead:
>
> $ git last-modified -- path/file
> aaa0aab1bbb2bcc3ccc4ddd5dde6eee7eff8fff9 path/file
>
> To achieve this, the default max-depth is changed to 0 and recursive is
> always enabled.
>
> The handling of option '-r' is modified to disable a max-depth,
> resulting in the behavior of this option to remain unchanged.
>
> No existing tests were modified, because there didn't exist any tests
> covering the example above. But more tests are added to cover this now.
>
> Signed-off-by: Toon Claes <toon@iotcl•com>
> ---
Thanks. I think this makes more sense.
>[snip]
> --- a/Documentation/git-last-modified.adoc
> +++ b/Documentation/git-last-modified.adoc
> @@ -25,13 +25,14 @@ OPTIONS
>
> `-r`::
> `--recursive`::
> - Instead of showing tree entries, step into subtrees and show all entries
> - inside them recursively.
> + Recursively traverse into all subtrees. By default, the command only
> + shows tree entries matching the `<pathspec>`. With this option, it
This should be s/`<pathspec>`/_<pathspec>_ since this is a `[synopsis]`
doc. But this is in `next` so it will have to be left for another time.
>[snip]
next prev parent reply other threads:[~2026-01-25 11:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 6:09 [PATCH 0/3] Expand and enhance git-last-modified(1) documentation Toon Claes
2025-11-26 6:09 ` [PATCH 1/3] last-modified: handle and document NUL termination Toon Claes
2025-11-26 13:03 ` Karthik Nayak
2025-11-26 16:57 ` Junio C Hamano
2025-11-28 18:50 ` Toon Claes
2025-12-01 10:32 ` Patrick Steinhardt
2025-11-26 6:09 ` [PATCH 2/3] last-modified: document option --max-depth Toon Claes
2025-11-26 13:31 ` Karthik Nayak
2026-01-16 12:13 ` Toon Claes
2025-11-26 19:49 ` Junio C Hamano
2025-11-28 18:51 ` Toon Claes
2025-11-26 6:09 ` [PATCH 3/3] last-modified: better document how depth in handled Toon Claes
2025-11-26 17:38 ` Eric Sunshine
2025-12-01 10:32 ` Patrick Steinhardt
2025-12-02 11:01 ` Toon Claes
2025-12-02 17:14 ` Patrick Steinhardt
2026-01-16 13:22 ` [PATCH v2 0/5] Change git-last-modified(1) default behavior and add documentation Toon Claes
2026-01-16 13:22 ` [PATCH v2 1/5] last-modified: document NUL termination Toon Claes
2026-01-16 13:22 ` [PATCH v2 2/5] last-modified: add option '-z' to help output Toon Claes
2026-01-16 18:31 ` Junio C Hamano
2026-01-16 13:22 ` [PATCH v2 3/5] last-modified: document option --max-depth Toon Claes
2026-01-16 13:22 ` [PATCH v2 4/5] last-modified: add option '--max-depth' to help output Toon Claes
2026-01-16 18:42 ` Junio C Hamano
2026-01-16 13:22 ` [PATCH v2 5/5] last-modified: change default max-depth to 0 Toon Claes
2026-01-16 18:55 ` Junio C Hamano
2026-01-16 13:34 ` [PATCH v2 0/5] Change git-last-modified(1) default behavior and add documentation Kristoffer Haugsbakk
2026-01-20 10:44 ` Toon Claes
2026-01-20 21:47 ` [PATCH v3 0/4] " Toon Claes
2026-01-20 21:47 ` [PATCH v3 1/4] last-modified: clarify in the docs the command takes a pathspec Toon Claes
2026-01-20 21:47 ` [PATCH v3 2/4] last-modified: document option '-z' Toon Claes
2026-01-20 21:47 ` [PATCH v3 3/4] last-modified: document option '--max-depth' Toon Claes
2026-01-20 21:47 ` [PATCH v3 4/4] last-modified: change default max-depth to 0 Toon Claes
2026-01-25 11:24 ` Kristoffer Haugsbakk [this message]
2026-01-21 18:40 ` [PATCH v3 0/4] Change git-last-modified(1) default behavior and add documentation Junio C Hamano
2026-02-03 9:58 ` Karthik Nayak
2026-02-03 17:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b97e8fd-1dfc-4a38-9c77-22467f38fd3b@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gusted@codeberg$(echo .)org \
--cc=toon@iotcl$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox