public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Keller, Jacob E" <jacob.e.keller@intel•com>
To: "sunshine@sunshineco•com" <sunshine@sunshineco•com>
Cc: "git@vger•kernel.org" <git@vger•kernel.org>,
	"gitster@pobox•com" <gitster@pobox•com>,
	"spearce@spearce•org" <spearce@spearce•org>,
	"felipe.contreras@gmail•com" <felipe.contreras@gmail•com>,
	"szeder@ira•uka.de" <szeder@ira•uka.de>,
	"jacob.keller@gmail•com" <jacob.keller@gmail•com>,
	"lee.marlow@gmail•com" <lee.marlow@gmail•com>
Subject: Re: [PATCH v2 2/2] completion: add support for completing email aliases
Date: Mon, 16 Nov 2015 23:40:46 +0000	[thread overview]
Message-ID: <1447717246.23262.11.camel@intel.com> (raw)
In-Reply-To: <CAPig+cST4iGdv0B91C_sWs85OMyw5c77ivjZ50xkbF+_uTr1YA@mail.gmail.com>

On Mon, 2015-11-16 at 18:33 -0500, Eric Sunshine wrote:
> On Sun, Nov 15, 2015 at 3:22 PM, Jacob Keller <jacob.e.keller@intel•c
> om> wrote:
> > Using the new --list-aliases option from git-send-email, add
> > completion
> > for --to, --cc, and --bcc with the available configured aliases.
> > 
> > Signed-off-by: Jacob Keller <jacob.keller@gmail•com>
> > ---
> > diff --git a/contrib/completion/git-completion.bash
> > b/contrib/completion/git-completion.bash
> > @@ -1711,6 +1712,15 @@ __git_send_email_suppresscc_options="author
> > self cc bodycc sob cccmd body all"
> > 
> >  _git_send_email ()
> >  {
> > +       case "$prev" in
> > +       --to|--cc|--bcc)
> 
> What about --from, which also undergoes alias expansion?
> 

Makes sense, yep.


  reply	other threads:[~2015-11-16 23:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-15 20:22 [PATCH v2 1/2] sendemail: teach git-send-email to list aliases Jacob Keller
2015-11-15 20:22 ` [PATCH v2 2/2] completion: add support for completing email aliases Jacob Keller
2015-11-16 23:33   ` Eric Sunshine
2015-11-16 23:40     ` Keller, Jacob E [this message]
2015-11-16 23:30 ` [PATCH v2 1/2] sendemail: teach git-send-email to list aliases Eric Sunshine
2015-11-16 23:40   ` Keller, Jacob E
2015-11-16 23:50     ` Eric Sunshine
2015-11-16 23:56       ` Eric Sunshine
2015-11-17  0:09         ` Keller, Jacob E
2015-11-17  0:10       ` Keller, Jacob E
2015-11-17  7:20         ` Eric Sunshine
2015-11-17  8:25           ` Jacob Keller
2015-11-17 12:26           ` SZEDER Gábor
2015-11-17 16:27             ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447717246.23262.11.camel@intel.com \
    --to=jacob.e.keller@intel$(echo .)com \
    --cc=felipe.contreras@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=jacob.keller@gmail$(echo .)com \
    --cc=lee.marlow@gmail$(echo .)com \
    --cc=spearce@spearce$(echo .)org \
    --cc=sunshine@sunshineco$(echo .)com \
    --cc=szeder@ira$(echo .)uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox