From: "Keller, Jacob E" <jacob.e.keller@intel•com>
To: "sunshine@sunshineco•com" <sunshine@sunshineco•com>
Cc: "git@vger•kernel.org" <git@vger•kernel.org>,
"gitster@pobox•com" <gitster@pobox•com>,
"spearce@spearce•org" <spearce@spearce•org>,
"lee.marlow@gmail•com" <lee.marlow@gmail•com>,
"felipe.contreras@gmail•com" <felipe.contreras@gmail•com>,
"szeder@ira•uka.de" <szeder@ira•uka.de>,
"jacob.keller@gmail•com" <jacob.keller@gmail•com>
Subject: Re: [PATCH v2 1/2] sendemail: teach git-send-email to list aliases
Date: Tue, 17 Nov 2015 00:10:35 +0000 [thread overview]
Message-ID: <1447719035.23262.17.camel@intel.com> (raw)
In-Reply-To: <CAPig+cSMW2UmTzuyvBFpcpr4tF1FRdxHUPH4+wS3vrZSP9AzJA@mail.gmail.com>
On Mon, 2015-11-16 at 18:50 -0500, Eric Sunshine wrote:
> It should be possible to extract the alias within the shell itself
> without a separate process. For instance:
>
> read alias rest
>
> will leave the first token in $alias and the remainder of the line in
> $rest, and it's all done within the shell process.
>
I'll look into this :)
> > > New test(s) seem to be missing.
> >
> > I had removed the tests from the old version because they weren't
> > necessary anymore. New ones wouldn't hurt here either, though..
> > I'll
> > work on that.
>
> I'm not sure which tests you mean, but I was referring to tests to
> make sure that git-send-email recognizes --list-aliases (or
> --dump-aliases if you switch to that) and that it produces the
> expected output in the expected format.
>
Yep, I added some in my respin.
> Also, shouldn't --list-aliases (or --dump-aliases) be mutually
> exclusive with many of the other options? New tests would check such
> exclusivity as well.
I am at a loss for how to do that correctly in the perl. Help would be
appreciated here.
Regards,
Jak
next prev parent reply other threads:[~2015-11-17 0:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-15 20:22 [PATCH v2 1/2] sendemail: teach git-send-email to list aliases Jacob Keller
2015-11-15 20:22 ` [PATCH v2 2/2] completion: add support for completing email aliases Jacob Keller
2015-11-16 23:33 ` Eric Sunshine
2015-11-16 23:40 ` Keller, Jacob E
2015-11-16 23:30 ` [PATCH v2 1/2] sendemail: teach git-send-email to list aliases Eric Sunshine
2015-11-16 23:40 ` Keller, Jacob E
2015-11-16 23:50 ` Eric Sunshine
2015-11-16 23:56 ` Eric Sunshine
2015-11-17 0:09 ` Keller, Jacob E
2015-11-17 0:10 ` Keller, Jacob E [this message]
2015-11-17 7:20 ` Eric Sunshine
2015-11-17 8:25 ` Jacob Keller
2015-11-17 12:26 ` SZEDER Gábor
2015-11-17 16:27 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447719035.23262.17.camel@intel.com \
--to=jacob.e.keller@intel$(echo .)com \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jacob.keller@gmail$(echo .)com \
--cc=lee.marlow@gmail$(echo .)com \
--cc=spearce@spearce$(echo .)org \
--cc=sunshine@sunshineco$(echo .)com \
--cc=szeder@ira$(echo .)uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox