From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Junio C Hamano" <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH] rev-list: update a NEEDSWORK comment
Date: Tue, 22 Jul 2025 10:41:02 +0200 [thread overview]
Message-ID: <1599cd31-436c-4ac7-bbef-be7dfbff00a3@app.fastmail.com> (raw)
In-Reply-To: <xmqqecu9w4a5.fsf@gitster.g>
On Tue, Jul 22, 2025, at 00:46, Junio C Hamano wrote:
> The comment was poorly phrased and it wasn't clear what it wanted to
> say. Strongly discourage this broken pattern to be copied and
> pasted to other code paths.
Why “was”? Shouldn’t it be “The comment is poorly phrased ... so
[change it]”. According to SubmittingPatches, “present-tense”.
/nitpick
next prev parent reply other threads:[~2025-07-22 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 23:58 [PATCH] rev-list: make "struct rev_list_info" static to the only user Junio C Hamano
2025-07-19 6:35 ` Jeff King
2025-07-19 12:36 ` René Scharfe
2025-07-20 0:04 ` Jeff King
2025-07-20 0:41 ` Junio C Hamano
2025-07-21 22:46 ` [PATCH] rev-list: update a NEEDSWORK comment Junio C Hamano
2025-07-22 8:16 ` Jeff King
2025-07-22 8:41 ` Kristoffer Haugsbakk [this message]
2025-07-22 13:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1599cd31-436c-4ac7-bbef-be7dfbff00a3@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox