From: "René Scharfe" <l.s.r@web•de>
To: Jeff King <peff@peff•net>, Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] rev-list: make "struct rev_list_info" static to the only user
Date: Sat, 19 Jul 2025 14:36:04 +0200 [thread overview]
Message-ID: <fc4da804-37ed-4425-8dda-14cfcb607906@web.de> (raw)
In-Reply-To: <20250719063551.GA705356@coredump.intra.peff.net>
On 7/19/25 8:35 AM, Jeff King wrote:
> On Fri, Jul 18, 2025 at 04:58:03PM -0700, Junio C Hamano wrote:
>
>> The structure has nothing to do with what "git bisect" does; as
>> nobody other than "git rev-list" implementation uses it, move it
>> as a private data type to builtin/rev-list.c
>
> Nice improvement.
*nod*
>> @@ -652,7 +660,7 @@ int cmd_rev_list(int argc,
>> */
>> /*
>> * NEEDSWORK: These loops that attempt to find presence of
>> - * options without understanding that the options they are
>> + * options without understanding the options they are
>> * skipping are broken (e.g., it would not know "--grep
>> * --exclude-promisor-objects" is not triggering
>> * "--exclude-promisor-objects" option). We really need
>
> This tacked-on bit seems funny to me. Isn't the original more correct?
> The loops do not understand that the options are broken.
No, the options are fine, but the loops are broken -- they cannot tell
what they are looking at is an option or an argument of a preceding
option, yet they ignore that latter possibility. So the word "that"
is best left out. I also don't see a connection to the struct move,
though.
René
next prev parent reply other threads:[~2025-07-19 12:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 23:58 [PATCH] rev-list: make "struct rev_list_info" static to the only user Junio C Hamano
2025-07-19 6:35 ` Jeff King
2025-07-19 12:36 ` René Scharfe [this message]
2025-07-20 0:04 ` Jeff King
2025-07-20 0:41 ` Junio C Hamano
2025-07-21 22:46 ` [PATCH] rev-list: update a NEEDSWORK comment Junio C Hamano
2025-07-22 8:16 ` Jeff King
2025-07-22 8:41 ` Kristoffer Haugsbakk
2025-07-22 13:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc4da804-37ed-4425-8dda-14cfcb607906@web.de \
--to=l.s.r@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox