From: Florian Achleitner <florian.achleitner.2.6.31@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: Florian Achleitner <florian.achleitner.2.6.31@gmail•com>,
David Michael Barr <b@rr-dav•id.au>,
git@vger•kernel.org, Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [RFC 1/5] GSOC: prepare svndump for branch detection
Date: Mon, 20 Aug 2012 15:35:53 +0200 [thread overview]
Message-ID: <1701463.olu8UUX9CV@flomedio> (raw)
In-Reply-To: <7v7gsum4oc.fsf@alter.siamese.dyndns.org>
On Sunday 19 August 2012 23:57:23 Junio C Hamano wrote:
> Florian Achleitner <florian.achleitner.2.6.31@gmail•com> writes:
> >> This change makes me uncomfortable.
> >> We are doubling up on hashing with fast-import.
> >> This introduces git-specific logic into vcs-svn.
>
> IIUC, vcs-svn/fast-export is meant to produce a stream in the
> fast-import format, and that format is meant to be VCS agnostic,
> it would need a careful thinking to add anything Git specific to
> it. If you make other people's importers unable to read from you
> because you tell them the contents of blob in Git's terms, that is
> not very good.
Good point.
>
> > You have two choices of referencing that blobs later, by using a mark, or
> > by giving their sha1. Marks are already used for marking commits, and
> > there is only one "mark namespace". So I couldn't use marks to reference
> > the blobs in a nice way. This allows for referencing them by their sha1.
>
> Surely you can, by using even and odd numbers (or modulo 4 if you
> may later want to mark trees and tags as well, but I doubt that is
> needed), no?
Currently, the mark number is equal to the svn revision number the commit
corresponds to. I didn't want to break that, but not mandatory. We could also
split the mark namespace by reserving one or more of the most significant bits
as a type specifier.
I'll develop a marks-based version ..
next prev parent reply other threads:[~2012-08-20 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 20:40 [RFC 1/5] GSOC: prepare svndump for branch detection Florian Achleitner
2012-08-17 20:40 ` [RFC 1/5] vcs-svn: Add sha1 calculaton to fast_export and line_buffer Florian Achleitner
2012-08-17 20:40 ` [RFC 2/5] svndump: move struct definitions to .h Florian Achleitner
2012-08-17 20:40 ` [RFC 3/5] vcs-svn/svndump: restructure node_ctx, rev_ctx handling Florian Achleitner
2012-08-17 20:40 ` [RFC 4/5] vcs-svn/svndump: rewrite handle_node(), begin|end_revision() Florian Achleitner
2012-08-17 20:40 ` [RFC 5/5] vcs-svn: remove repo_tree Florian Achleitner
2012-08-18 18:37 ` [RFC 1/5] GSOC: prepare svndump for branch detection David Michael Barr
2012-08-20 6:26 ` Florian Achleitner
2012-08-20 6:57 ` Junio C Hamano
2012-08-20 13:35 ` Florian Achleitner [this message]
2012-08-20 16:45 ` Jonathan Nieder
2012-08-20 17:43 ` Florian Achleitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1701463.olu8UUX9CV@flomedio \
--to=florian.achleitner.2.6.31@gmail$(echo .)com \
--cc=b@rr-dav$(echo .)id.au \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox