From: Florian Achleitner <florian.achleitner.2.6.31@gmail•com>
To: David Michael Barr <b@rr-dav•id.au>
Cc: Florian Achleitner <florian.achleitner.2.6.31@gmail•com>,
git@vger•kernel.org, Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [RFC 1/5] GSOC: prepare svndump for branch detection
Date: Sun, 19 Aug 2012 23:26:04 -0700 (PDT) [thread overview]
Message-ID: <5679616.CtEd2rlvlO@flomedio> (raw)
In-Reply-To: <CACPE+fvkTNNHXbFTwhoH7=aQKoc9YqtfTBOkJDugUogni0sYww@mail.gmail.com>
On Sunday 19 August 2012 04:37:35 David Michael Barr wrote:
> On Sat, Aug 18, 2012 at 6:40 AM, Florian Achleitner
>
> <florian.achleitner.2.6.31@gmail•com> wrote:
> > Hi!
> >
> > This patch series should prepare vcs-svn/svndump.* for branch
> > detection. When starting with this feature I found that the existing
> > functions are not yet appropriate for that.
> > These rewrites the node handling part of svndump.c, it is very
> > invasive. The logic in handle_node is not simple, I hope that I
> > understood every case the existing code tries to adress.
> > At least it doesn't break an existing testcase.
> >
> > The series applies on top of:
> > [PATCH/RFC v4 16/16] Add a test script for remote-svn.
> > I could also rebase it onto master if you think it makes sense.
> >
> > Florian
> >
> > [RFC 1/5] vcs-svn: Add sha1 calculaton to fast_export and
>
> This change makes me uncomfortable.
> We are doubling up on hashing with fast-import.
> This introduces git-specific logic into vcs-svn.
You might need to read the rest of the series to see why I did this.
Short version: For fast-import, I seperated sending data from the commits, it
is sent using the 'blob' command.
You have two choices of referencing that blobs later, by using a mark, or by
giving their sha1. Marks are already used for marking commits, and there is
only one "mark namespace". So I couldn't use marks to reference the blobs in
a nice way. This allows for referencing them by their sha1.
>
> > [RFC 2/5] svndump: move struct definitions to .h.
> > [RFC 3/5] vcs-svn/svndump: restructure node_ctx, rev_ctx handling
> > [RFC 4/5] vcs-svn/svndump: rewrite handle_node(),
> > [RFC 5/5] vcs-svn: remove repo_tree
>
> I haven't read the rest of the series yet but I expect
> it is less controversial than the first patch.
Hm.. I'm not sure ;)
>
> --
> David Michael Barr
Florian
next prev parent reply other threads:[~2012-08-20 6:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 20:40 [RFC 1/5] GSOC: prepare svndump for branch detection Florian Achleitner
2012-08-17 20:40 ` [RFC 1/5] vcs-svn: Add sha1 calculaton to fast_export and line_buffer Florian Achleitner
2012-08-17 20:40 ` [RFC 2/5] svndump: move struct definitions to .h Florian Achleitner
2012-08-17 20:40 ` [RFC 3/5] vcs-svn/svndump: restructure node_ctx, rev_ctx handling Florian Achleitner
2012-08-17 20:40 ` [RFC 4/5] vcs-svn/svndump: rewrite handle_node(), begin|end_revision() Florian Achleitner
2012-08-17 20:40 ` [RFC 5/5] vcs-svn: remove repo_tree Florian Achleitner
2012-08-18 18:37 ` [RFC 1/5] GSOC: prepare svndump for branch detection David Michael Barr
2012-08-20 6:26 ` Florian Achleitner [this message]
2012-08-20 6:57 ` Junio C Hamano
2012-08-20 13:35 ` Florian Achleitner
2012-08-20 16:45 ` Jonathan Nieder
2012-08-20 17:43 ` Florian Achleitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5679616.CtEd2rlvlO@flomedio \
--to=florian.achleitner.2.6.31@gmail$(echo .)com \
--cc=b@rr-dav$(echo .)id.au \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox