From: "David D. Kilzer" <ddkilzer@kilzer•net>
To: Eric Wong <normalperson@yhbt•net>, Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: Re: Intermittent failures in t9119
Date: Fri, 31 Dec 2010 06:13:56 -0800 (PST) [thread overview]
Message-ID: <190893.69491.qm@web30005.mail.mud.yahoo.com> (raw)
In-Reply-To: <20101209175503.GA16478@dcvr.yhbt.net>
Eric Wong <normalperson@yhbt•net> wrote:
> Junio C Hamano <gitster@pobox•com> wrote:
> > Eric Wong <normalperson@yhbt•net> writes:
> > > Junio C Hamano <gitster@pobox•com> wrote:
> > >> (2) Nobody uses the value from "Text Last Updated" field in practice,
>so
> > >> that bug has been unnoticed so far;
> > >>
> > >> (3) And it is not worth fixing it ;-)
> > >>
> > >> For now, I would suggest fixing the failing test to ignore the "Text
Last
> > >> Updated" field while comparing, and if somebody is inclined to, we would
> > >> update the code to match what "svn info" does.
> > >
> > > Agreed on both points. I consider "git svn log" and "git svn info" to
> > > be reasonable approximations of svn behavior, not exact replicas.
> > > Exactly matching would be extremely difficult given variations between
> > > different svn versions, and also svn requiring network access while
> > > git svn does not.
> >
> > Ok, here is a minimum patch to do that.
>
> > Signed-off-by: Junio C Hamano <gitster@pobox•com>
>
> Thanks, Acked-by: Eric Wong <normalperson@yhbt•net>
Acked-by: David Kilzer <ddkilzer@kilzer•net>
Thanks!
Dave
prev parent reply other threads:[~2010-12-31 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 2:19 Intermittent failures in t9119 Junio C Hamano
2010-12-05 1:21 ` David D. Kilzer
2010-12-05 4:50 ` Junio C Hamano
2010-12-05 20:39 ` Junio C Hamano
2010-12-06 19:10 ` Eric Wong
2010-12-07 0:00 ` Junio C Hamano
2010-12-09 17:55 ` Eric Wong
2010-12-31 14:13 ` David D. Kilzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=190893.69491.qm@web30005.mail.mud.yahoo.com \
--to=ddkilzer@kilzer$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=normalperson@yhbt$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox