From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Olamide Caleb Bello" <belkid98@gmail•com>
Cc: git@vger•kernel.org, "Junio C Hamano" <gitster@pobox•com>,
"Usman Akinyemi" <usmanakinyemi202@gmail•com>,
"Christian Couder" <christian.couder@gmail•com>
Subject: Re: [Outreachy PATCH v3 1/2] gpg-interface: replace strbuf_split*() with string_list_split*()
Date: Mon, 20 Oct 2025 20:37:15 +0200 [thread overview]
Message-ID: <1cdc170b-569d-4874-b1d8-dd645c0545b0@app.fastmail.com> (raw)
In-Reply-To: <CAD=f0L_4O9oLxUToLn3QwDopFCnYAKQwBPOXwb+xuPkqXh=p1A@mail.gmail.com>
On Mon, Oct 20, 2025, at 20:25, Bello Olamide wrote:
> On Mon, 20 Oct 2025 at 17:46, Kristoffer Haugsbakk
> <kristofferhaugsbakk@fastmail•com> wrote:
>> Signoff should go at the end of the commit message. You’re saying that
>> you are signing off on the changes as well as what was written in the
>> commit message before that line. If I later add mine:
>>
>> Signed-off-by: Olamide Caleb Bello <belkid98@gmail•com>
>> Signed-off-by: ME
>>
>> I would be saying that I am signing off on the changes as well as the
>> previous lines in the commit message, including that line that you
>> wrote.
>
> Please just to make sure I get you correctly, you are saying the Signoff
> should be the last thing in the commit message.
>
> Like I should put it below the other tags so that if you also want to add yours,
> It can easily go below mine and it would mean you are signing off on the
> changes including my own Signoff?
>
>>
>> > Reported-by: Junio Hamano <gitster@pobox•com>
>> > Helped-by: Christian Couder <christian.couder@gmail•com>
>> > Helped-by: Junio Hamano <gitster@pobox•com>
> It should go below here instead?
Yes, that is my understanding. :)
next prev parent reply other threads:[~2025-10-20 18:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-19 12:07 [Outreachy PATCH v3 0/2] gpg-interface.c: use string_list_split*() instead of strbuf_split*() Olamide Caleb Bello
2025-10-19 12:07 ` [Outreachy PATCH v3 1/2] gpg-interface: replace strbuf_split*() with string_list_split*() Olamide Caleb Bello
2025-10-19 15:52 ` Junio C Hamano
2025-10-20 6:32 ` Bello Olamide
2025-10-20 15:09 ` Junio C Hamano
2025-10-20 16:31 ` Junio C Hamano
2025-10-20 18:15 ` Bello Olamide
2025-10-20 18:12 ` Bello Olamide
2025-10-20 16:45 ` Kristoffer Haugsbakk
2025-10-20 18:25 ` Bello Olamide
2025-10-20 18:37 ` Kristoffer Haugsbakk [this message]
2025-10-20 18:50 ` Bello Olamide
2025-10-19 12:07 ` [Outreachy PATCH v3 2/2] gpg-interface: use string_list_split*() instead of strbuf_split*() Olamide Caleb Bello
2025-10-19 16:00 ` Junio C Hamano
2025-10-20 8:15 ` Bello Olamide
2025-10-20 15:18 ` Junio C Hamano
2025-10-20 19:02 ` Bello Olamide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cdc170b-569d-4874-b1d8-dd645c0545b0@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=belkid98@gmail$(echo .)com \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=usmanakinyemi202@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox