From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Olamide Caleb Bello" <belkid98@gmail•com>, git@vger•kernel.org
Cc: "Junio C Hamano" <gitster@pobox•com>,
"Usman Akinyemi" <usmanakinyemi202@gmail•com>,
"Christian Couder" <christian.couder@gmail•com>
Subject: Re: [Outreachy PATCH v3 1/2] gpg-interface: replace strbuf_split*() with string_list_split*()
Date: Mon, 20 Oct 2025 18:45:56 +0200 [thread overview]
Message-ID: <4bd36d2e-7629-41bf-9731-493cf3bd151a@app.fastmail.com> (raw)
In-Reply-To: <7da4fded535984faea52d5f88793d3c8e47c0091.1760869186.git.belkid98@gmail.com>
On Sun, Oct 19, 2025, at 14:07, Olamide Caleb Bello wrote:
>[snip]
>
> Signed-off-by: Olamide Caleb Bello <belkid98@gmail•com>
Signoff should go at the end of the commit message. You’re saying that
you are signing off on the changes as well as what was written in the
commit message before that line. If I later add mine:
Signed-off-by: Olamide Caleb Bello <belkid98@gmail•com>
Signed-off-by: ME
I would be saying that I am signing off on the changes as well as the
previous lines in the commit message, including that line that you
wrote.
> Reported-by: Junio Hamano <gitster@pobox•com>
> Helped-by: Christian Couder <christian.couder@gmail•com>
> Helped-by: Junio Hamano <gitster@pobox•com>
> ---
> gpg-interface.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>[snip]
next prev parent reply other threads:[~2025-10-20 16:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-19 12:07 [Outreachy PATCH v3 0/2] gpg-interface.c: use string_list_split*() instead of strbuf_split*() Olamide Caleb Bello
2025-10-19 12:07 ` [Outreachy PATCH v3 1/2] gpg-interface: replace strbuf_split*() with string_list_split*() Olamide Caleb Bello
2025-10-19 15:52 ` Junio C Hamano
2025-10-20 6:32 ` Bello Olamide
2025-10-20 15:09 ` Junio C Hamano
2025-10-20 16:31 ` Junio C Hamano
2025-10-20 18:15 ` Bello Olamide
2025-10-20 18:12 ` Bello Olamide
2025-10-20 16:45 ` Kristoffer Haugsbakk [this message]
2025-10-20 18:25 ` Bello Olamide
2025-10-20 18:37 ` Kristoffer Haugsbakk
2025-10-20 18:50 ` Bello Olamide
2025-10-19 12:07 ` [Outreachy PATCH v3 2/2] gpg-interface: use string_list_split*() instead of strbuf_split*() Olamide Caleb Bello
2025-10-19 16:00 ` Junio C Hamano
2025-10-20 8:15 ` Bello Olamide
2025-10-20 15:18 ` Junio C Hamano
2025-10-20 19:02 ` Bello Olamide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bd36d2e-7629-41bf-9731-493cf3bd151a@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=belkid98@gmail$(echo .)com \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=usmanakinyemi202@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox