* [PATCH] fix git-revert command-line options [not found] <20060803153742.109978@dial-up-mi-12.lombardiacom.it> @ 2006-08-03 15:42 ` Michael 2006-08-03 18:41 ` Martin Waitz 1 sibling, 0 replies; 4+ messages in thread From: Michael @ 2006-08-03 15:42 UTC (permalink / raw) To: git Signed-off-by: Michael <barra_cuda@katamail•com> --- git-revert.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/git-revert.sh b/git-revert.sh index 2bf35d1..195c3ba 100755 --- a/git-revert.sh +++ b/git-revert.sh @@ -22,14 +22,14 @@ no_commit= replay= while case "$#" in 0) break ;; esac do case "$1" in - -n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\ + -n|--no-c|--no-co|--no-com|--no-comm|\ --no-commi|--no-commit) no_commit=t ;; -e|--e|--ed|--edi|--edit) edit=-e ;; - --n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit) + --n|--no-e|--no-ed|--no-edi|--no-edit) edit= ;; -r|--r|--re|--rep|--repl|--repla|--replay) -- 1.4.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fix git-revert command-line options [not found] <20060803153742.109978@dial-up-mi-12.lombardiacom.it> 2006-08-03 15:42 ` [PATCH] fix git-revert command-line options Michael @ 2006-08-03 18:41 ` Martin Waitz 2006-08-03 19:31 ` Junio C Hamano 1 sibling, 1 reply; 4+ messages in thread From: Martin Waitz @ 2006-08-03 18:41 UTC (permalink / raw) To: Michael; +Cc: git [-- Attachment #1: Type: text/plain, Size: 486 bytes --] hoi :) On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote: > - -n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\ > + -n|--no-c|--no-co|--no-com|--no-comm|\ > - --n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit) > + --n|--no-e|--no-ed|--no-edi|--no-edit) well spottet, but now we still have "-n" versus "--n". Perhaps we should drop the single-letter options or at least only keep one of them and then explicitly document that in the manpage. -- Martin Waitz [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix git-revert command-line options 2006-08-03 18:41 ` Martin Waitz @ 2006-08-03 19:31 ` Junio C Hamano [not found] ` <20060803204417.516906@dial-up-mi-300.lombardiacom.it> 0 siblings, 1 reply; 4+ messages in thread From: Junio C Hamano @ 2006-08-03 19:31 UTC (permalink / raw) To: Martin Waitz; +Cc: git Martin Waitz <tali@admingilde•org> writes: > On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote: >> - -n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\ >> + -n|--no-c|--no-co|--no-com|--no-comm|\ > >> - --n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit) >> + --n|--no-e|--no-ed|--no-edi|--no-edit) > > well spottet, but now we still have "-n" versus "--n". > Perhaps we should drop the single-letter options or at least only > keep one of them and then explicitly document that in the manpage. Good suggestion. ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20060803204417.516906@dial-up-mi-300.lombardiacom.it>]
* Re: [PATCH] fix git-revert command-line options [not found] ` <20060803204417.516906@dial-up-mi-300.lombardiacom.it> @ 2006-08-03 20:48 ` Michael 0 siblings, 0 replies; 4+ messages in thread From: Michael @ 2006-08-03 20:48 UTC (permalink / raw) To: Junio C Hamano; +Cc: git, Martin Waitz Junio C Hamano wrote: > Martin Waitz <tali@admingilde•org> writes: > > On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote: > >> - -n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\ > >> + -n|--no-c|--no-co|--no-com|--no-comm|\ > >> > >> - --n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit) > >> + --n|--no-e|--no-ed|--no-edi|--no-edit) > > > > well spottet, but now we still have "-n" versus "--n". > > Perhaps we should drop the single-letter options or at least only > > keep one of them and then explicitly document that in the manpage. > > Good suggestion. Well, I left "--n" for the lazy typers, but it's too confusing - and can be easy misremembered. I'd leave "-n" for "--no-commit", though (and it's already on man page). Your choice. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-08-03 20:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20060803153742.109978@dial-up-mi-12.lombardiacom.it>
2006-08-03 15:42 ` [PATCH] fix git-revert command-line options Michael
2006-08-03 18:41 ` Martin Waitz
2006-08-03 19:31 ` Junio C Hamano
[not found] ` <20060803204417.516906@dial-up-mi-300.lombardiacom.it>
2006-08-03 20:48 ` Michael
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox