From: Robin Rosenberg <robin.rosenberg.lists@dewire•com>
To: Junio C Hamano <junkio@cox•net>
Cc: "David Kågedal" <davidk@lysator•liu.se>, git@vger•kernel.org
Subject: Re: [PATCH] Reencode committer info to utf-8 before formatting mail header
Date: Sat, 13 Jan 2007 13:23:52 +0100 [thread overview]
Message-ID: <200701131323.53121.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <7vmz4nog5b.fsf@assigned-by-dhcp.cox.net>
lördag 13 januari 2007 02:43 skrev Junio C Hamano:
> Side note. The previous patch does not help if your commit were
> made in non UTF-8 with not too recent git; the code assumes that
> commit messages without the new "encoding" headers are in UTF-8.
Wasn't there a repository option, "commitencoding"? I can't see it being
used here. I.e., we should err out if the log message is not UTF-8 and the
option is not set (giving a message telling the user to set it). If it is
set we should consider the repository encoding to be the one and if that too
is wrong (only possible to detect for some encodings), just assume iso-8859-1
as anything could in theory be iso-8859-1 encoded.
-- robin
next prev parent reply other threads:[~2007-01-13 12:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-12 13:06 [PATCH] Reencode committer info to utf-8 before formatting mail header David Kågedal
2007-01-12 22:11 ` Junio C Hamano
2007-01-13 1:31 ` Junio C Hamano
2007-01-13 1:43 ` Junio C Hamano
2007-01-13 11:19 ` Johannes Schindelin
2007-01-13 17:57 ` Junio C Hamano
2007-01-15 16:58 ` David Kågedal
2007-01-16 11:41 ` Johannes Schindelin
2007-01-16 12:43 ` David Kågedal
2007-01-13 12:23 ` Robin Rosenberg [this message]
2007-01-13 17:54 ` Junio C Hamano
2007-01-15 16:54 ` David Kågedal
2007-01-13 11:02 ` Alex Riesen
2007-01-14 0:42 ` Horst H. von Brand
2007-01-14 19:25 ` Alex Riesen
2007-01-13 22:18 ` Junio C Hamano
2007-01-15 16:57 ` David Kågedal
2007-01-15 16:53 ` David Kågedal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701131323.53121.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire$(echo .)com \
--cc=davidk@lysator$(echo .)liu.se \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox