From: "David Kågedal" <davidk@lysator•liu.se>
To: git@vger•kernel.org
Subject: Re: [PATCH] Reencode committer info to utf-8 before formatting mail header
Date: Mon, 15 Jan 2007 17:53:29 +0100 [thread overview]
Message-ID: <87k5zo44fq.fsf@morpheus.local> (raw)
In-Reply-To: 7vd55jrj38.fsf@assigned-by-dhcp.cox.net
Junio C Hamano <junkio@cox•net> writes:
>> diff --git a/utf8.h b/utf8.h
>> index a07c5a8..eb64d46 100644
>> --- a/utf8.h
>> +++ b/utf8.h
>> @@ -8,7 +8,7 @@ int is_encoding_utf8(const char *name);
>> void print_wrapped_text(const char *text, int indent, int indent2, int len);
>>
>> #ifndef NO_ICONV
>> -char *reencode_string(const char *in, const char *out_encoding, const char *in_encoding);
>> +char *reencode_string(const char *in, const char *out_encoding, const char *in_encoding, int *len);
>> #else
>> #define reencode_string(a,b,c) NULL
>> #endif
>
> This feels fishy...
I admit that I didn't test-compile with NO_ICONV.
--
David Kågedal
prev parent reply other threads:[~2007-01-15 22:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-12 13:06 [PATCH] Reencode committer info to utf-8 before formatting mail header David Kågedal
2007-01-12 22:11 ` Junio C Hamano
2007-01-13 1:31 ` Junio C Hamano
2007-01-13 1:43 ` Junio C Hamano
2007-01-13 11:19 ` Johannes Schindelin
2007-01-13 17:57 ` Junio C Hamano
2007-01-15 16:58 ` David Kågedal
2007-01-16 11:41 ` Johannes Schindelin
2007-01-16 12:43 ` David Kågedal
2007-01-13 12:23 ` Robin Rosenberg
2007-01-13 17:54 ` Junio C Hamano
2007-01-15 16:54 ` David Kågedal
2007-01-13 11:02 ` Alex Riesen
2007-01-14 0:42 ` Horst H. von Brand
2007-01-14 19:25 ` Alex Riesen
2007-01-13 22:18 ` Junio C Hamano
2007-01-15 16:57 ` David Kågedal
2007-01-15 16:53 ` David Kågedal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k5zo44fq.fsf@morpheus.local \
--to=davidk@lysator$(echo .)liu.se \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox