From: "Shawn O. Pearce" <spearce@spearce•org>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Theodore Tso <tytso@mit•edu>,
James Bowes <jbowes@dangerouslyinc•com>,
git@vger•kernel.org
Subject: Re: [PATCH 0/2] Make gc a builtin.
Date: Mon, 12 Mar 2007 10:29:36 -0400 [thread overview]
Message-ID: <20070312142936.GD15150@spearce.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0703121222350.22628@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx•de> wrote:
> On Sun, 11 Mar 2007, Theodore Tso wrote:
>
> > On Sun, Mar 11, 2007 at 06:06:56PM -0400, James Bowes wrote:
> > > The following two patches make git-gc a builtin command.
> >
> > What's the advantage in making git-gc a builtin command?
>
> Portability. Plus, James wanted to get involved in Git development, and
> building in gc really was the shortest path into that.
Actually, git-gc.sh is pretty portable. To POSIX systems.
Windows ain't POSIX. Getting rid of some of those shell scripts
just makes us more portable, even to Windows. (Yes, people really
do still get forced to use that non-operating system.)
Ted talked about git-commit.sh being more important, but Dsco
clipped it. ;-)
I think git-commit.sh and git-merge.sh should both get ported to
builtins too, as both are somewhat hairy in shell, are quite core
to the system, and would be faster on Windows if written in C
(less forking == more speed there).
But they are so core that any rewrite must be undertaken carefully.
--
Shawn.
prev parent reply other threads:[~2007-03-12 14:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-11 22:06 [PATCH 0/2] Make gc a builtin James Bowes
2007-03-11 22:06 ` [PATCH 1/2] run-command: Make run_command_va_opt public and add run_command_va James Bowes
2007-03-11 22:06 ` [PATCH 2/2] Make gc a builtin James Bowes
2007-03-11 22:48 ` Johannes Schindelin
2007-03-12 2:11 ` Junio C Hamano
2007-03-12 2:51 ` [PATCH] " James Bowes
2007-03-12 14:43 ` Shawn O. Pearce
2007-03-12 3:07 ` [PATCH 2/2] " Johannes Schindelin
2007-03-12 2:57 ` [PATCH 0/2] " Theodore Tso
2007-03-12 11:23 ` Johannes Schindelin
2007-03-12 13:36 ` Theodore Tso
2007-03-12 19:14 ` Linus Torvalds
2007-03-13 0:48 ` Jakub Narebski
2007-03-13 1:20 ` Linus Torvalds
2007-03-12 14:29 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312142936.GD15150@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=jbowes@dangerouslyinc$(echo .)com \
--cc=tytso@mit$(echo .)edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox