From: "Shawn O. Pearce" <spearce@spearce•org>
To: Jonas Fonseca <fonseca@diku•dk>
Cc: git@vger•kernel.org, Junio C Hamano <junkio@cox•net>
Subject: Re: [PATCH] Update bash completion to ignore some more plumbing commands
Date: Mon, 21 May 2007 02:12:28 -0400 [thread overview]
Message-ID: <20070521061228.GJ3141@spearce.org> (raw)
In-Reply-To: <20070519213521.GA32221@diku.dk>
Jonas Fonseca <fonseca@diku•dk> wrote:
> Signed-off-by: Jonas Fonseca <fonseca@diku•dk>
> ---
> contrib/completion/git-completion.bash | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
OK, sorry this missed 1.5.2. I've applied it into my fastimport
master branch, I guess it will be in the next 1.5.2 based release.
;-)
> I am not sure if it is OK to exclude checkout-index as it is
> the only method of exporting the source as a directory. Also,
It might make sense to exclude checkout-index as plumbing, but I
use it myself so often (and tab complete it too) that I want to
keep it in. So I deleted that one line out of your patch when I
applied it.
> I don't understand why git-diff-* is not excluded.
Because I personally also use git diff-tree a lot. The others
(diff-files, diff-index) I *never* use directly so I'm thinking
maybe they should get flagged as plumbing and get removed from
the completion.
--
Shawn.
next prev parent reply other threads:[~2007-05-21 6:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-19 21:35 [PATCH] Update bash completion to ignore some more plumbing commands Jonas Fonseca
2007-05-21 6:12 ` Shawn O. Pearce [this message]
2007-05-22 21:06 ` Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070521061228.GJ3141@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=fonseca@diku$(echo .)dk \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox