public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: "Shawn O. Pearce" <spearce@spearce•org>
To: Jonathan del Strother <maillist@steelskies•com>
Cc: "Michele Ballabio" <barra_cuda@katamail•com>,
	git@vger•kernel.org, "André Goddard Rosa" <andre_rosa@lge•com>
Subject: Re: [REGRESSION] git-gui
Date: Thu, 3 Apr 2008 21:33:56 -0400	[thread overview]
Message-ID: <20080404013356.GM10274@spearce.org> (raw)
In-Reply-To: <20080404012723.GL10274@spearce.org>

"Shawn O. Pearce" <spearce@spearce•org> wrote:
> Jonathan del Strother <maillist@steelskies•com> wrote:
> > >  > >  # git gui
> > >  > >  Error in startup script: bad event type or keysym "["
> > >  > >     while executing
> > >  > >  "bind $ui_comm <$M1B-Key-\[> {show_less_context;break}"
> 
> > >  These changes should help (haven't tried):
> > >         \[ -> bracketleft
> > >         \] -> bracketright
> > >  but some European keyboards do not have easy access to brackets, so
> > >  other keys would be preferable (comma and period, for example, or 1 and 2).
> 
> I wrote up a patch today based on Michele's suggested change.

Hmm, maybe I should offer the patch.  :-)

--8>--
Subject: [PATCH] git-gui: Switch keybindings for [ and ] to bracketleft and bracketright

Thanks to Michele Ballabio for the quick fix.
This resolves the error introduced by c91ee2bd61.

Signed-off-by: Shawn O. Pearce <spearce@spearce•org>
---
 git-gui.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/git-gui.sh b/git-gui.sh
index d4e4c17..1a67105 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -2739,8 +2739,8 @@ bind $ui_comm <$M1B-Key-v> {tk_textPaste %W; %W see insert; break}
 bind $ui_comm <$M1B-Key-V> {tk_textPaste %W; %W see insert; break}
 bind $ui_comm <$M1B-Key-a> {%W tag add sel 0.0 end;break}
 bind $ui_comm <$M1B-Key-A> {%W tag add sel 0.0 end;break}
-bind $ui_comm <$M1B-Key-\[> {show_less_context;break}
-bind $ui_comm <$M1B-Key-\]> {show_more_context;break}
+bind $ui_comm <$M1B-Key-bracketleft> {show_less_context;break}
+bind $ui_comm <$M1B-Key-bracketright> {show_more_context;break}
 
 bind $ui_diff <$M1B-Key-x> {tk_textCopy %W;break}
 bind $ui_diff <$M1B-Key-X> {tk_textCopy %W;break}
@@ -2784,8 +2784,8 @@ bind .   <$M1B-Key-t> do_add_selection
 bind .   <$M1B-Key-T> do_add_selection
 bind .   <$M1B-Key-i> do_add_all
 bind .   <$M1B-Key-I> do_add_all
-bind .   <$M1B-Key-\[> {show_less_context;break}
-bind .   <$M1B-Key-\]> {show_more_context;break}
+bind .   <$M1B-Key-bracketleft> {show_less_context;break}
+bind .   <$M1B-Key-bracketright> {show_more_context;break}
 bind .   <$M1B-Key-Return> do_commit
 foreach i [list $ui_index $ui_workdir] {
 	bind $i <Button-1>       "toggle_or_diff         $i %x %y; break"
-- 
1.5.5.rc3.148.gb77a7


-- 
Shawn.

next prev parent reply	other threads:[~2008-04-04  1:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-03 13:43 [REGRESSION] git-gui André Goddard Rosa
2008-04-03 14:00 ` Jonathan del Strother
2008-04-03 14:34   ` RES: " André Goddard Rosa
2008-04-03 21:04   ` Michele Ballabio
2008-04-03 23:15     ` Jonathan del Strother
2008-04-04  1:27       ` Shawn O. Pearce
2008-04-04  1:33         ` Shawn O. Pearce [this message]
2008-04-04 11:02           ` Marco Roeland
2008-04-04 11:20             ` RES: " André Goddard Rosa
2008-04-04 21:04         ` Michele Ballabio
2008-04-05  4:01           ` Shawn O. Pearce
2008-04-07  7:38       ` David Kågedal
2008-04-07  8:10         ` Teemu Likonen
2008-04-08  2:18           ` Shawn O. Pearce
  -- strict thread matches above, loose matches on Subject: below --
2008-04-04 17:58 Brett Schwarz

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:d4e4c17 dfblob:1a67105 )
 OR (
bs:"git-gui: Switch keybindings for [ and ] to bracketleft and bracketright" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080404013356.GM10274@spearce.org \
    --to=spearce@spearce$(echo .)org \
    --cc=andre_rosa@lge$(echo .)com \
    --cc=barra_cuda@katamail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=maillist@steelskies$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox