public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce•org>
To: Michele Ballabio <barra_cuda@katamail•com>
Cc: git@vger•kernel.org,
	"Jonathan del Strother" <maillist@steelskies•com>,
	"André Goddard Rosa" <andre_rosa@lge•com>
Subject: Re: [REGRESSION] git-gui
Date: Sat, 5 Apr 2008 00:01:06 -0400	[thread overview]
Message-ID: <20080405040106.GW10274@spearce.org> (raw)
In-Reply-To: <200804042304.42794.barra_cuda@katamail.com>

Michele Ballabio <barra_cuda@katamail•com> wrote:
> 
> So, it doesn't recognize [ at all at the keysym (%K) level.
> No idea why. This is Tcl/Tk 8.4.15 on Linux.
...
> ctrl-+ and ctrl-=	-> more context
> ctrl--			-> less context

This is reasonable.  I like.
 
>  	.mbar.commit add command -label [mc "Show Less Context"] \
>  		-command show_less_context \
> -		-accelerator $M1T-\[
> +		-accelerator $M1T-\-
>  
>  	.mbar.commit add command -label [mc "Show More Context"] \
>  		-command show_more_context \
> -		-accelerator $M1T-\]
> +		-accelerator "$M1T-+ $M1T-="

Sadly Mac OS X does not like this accelerator in the menu.
It drops the accelerator entirely and just shows nothing.
I changed it to show "$M1T-=", but kept the bindings as
you had them below, so $M1T-+ is an alias.
  
> @@ -2715,8 +2715,11 @@ bind $ui_comm <$M1B-Key-v> {tk_textPaste %W; %W see insert; break}
>  bind $ui_comm <$M1B-Key-V> {tk_textPaste %W; %W see insert; break}
>  bind $ui_comm <$M1B-Key-a> {%W tag add sel 0.0 end;break}
>  bind $ui_comm <$M1B-Key-A> {%W tag add sel 0.0 end;break}
> -bind $ui_comm <$M1B-Key-bracketleft> {show_less_context;break}
> -bind $ui_comm <$M1B-Key-bracketright> {show_more_context;break}
> +bind $ui_comm <$M1B-Key-minus> {show_less_context;break}
> +bind $ui_comm <$M1B-Key-KP_Subtract> {show_less_context;break}
> +bind $ui_comm <$M1B-Key-equal> {show_more_context;break}
> +bind $ui_comm <$M1B-Key-plus> {show_more_context;break}
> +bind $ui_comm <$M1B-Key-KP_Add> {show_more_context;break}
>  
>  bind $ui_diff <$M1B-Key-x> {tk_textCopy %W;break}
>  bind $ui_diff <$M1B-Key-X> {tk_textCopy %W;break}
> @@ -2760,8 +2763,11 @@ bind .   <$M1B-Key-t> do_add_selection
>  bind .   <$M1B-Key-T> do_add_selection
>  bind .   <$M1B-Key-i> do_add_all
>  bind .   <$M1B-Key-I> do_add_all
> -bind .   <$M1B-Key-bracketleft> {show_less_context;break}
> -bind .   <$M1B-Key-bracketright> {show_more_context;break}
> +bind .   <$M1B-Key-minus> {show_less_context;break}
> +bind .   <$M1B-Key-KP_Subtract> {show_less_context;break}
> +bind .   <$M1B-Key-equal> {show_more_context;break}
> +bind .   <$M1B-Key-plus> {show_more_context;break}
> +bind .   <$M1B-Key-KP_Add> {show_more_context;break}
>  bind .   <$M1B-Key-Return> do_commit
>  foreach i [list $ui_index $ui_workdir] {
>  	bind $i <Button-1>       "toggle_or_diff         $i %x %y; break"
> -- 
> 1.5.4.5
> 

-- 
Shawn.

  reply	other threads:[~2008-04-05  4:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-03 13:43 [REGRESSION] git-gui André Goddard Rosa
2008-04-03 14:00 ` Jonathan del Strother
2008-04-03 14:34   ` RES: " André Goddard Rosa
2008-04-03 21:04   ` Michele Ballabio
2008-04-03 23:15     ` Jonathan del Strother
2008-04-04  1:27       ` Shawn O. Pearce
2008-04-04  1:33         ` Shawn O. Pearce
2008-04-04 11:02           ` Marco Roeland
2008-04-04 11:20             ` RES: " André Goddard Rosa
2008-04-04 21:04         ` Michele Ballabio
2008-04-05  4:01           ` Shawn O. Pearce [this message]
2008-04-07  7:38       ` David Kågedal
2008-04-07  8:10         ` Teemu Likonen
2008-04-08  2:18           ` Shawn O. Pearce
  -- strict thread matches above, loose matches on Subject: below --
2008-04-04 17:58 Brett Schwarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080405040106.GW10274@spearce.org \
    --to=spearce@spearce$(echo .)org \
    --cc=andre_rosa@lge$(echo .)com \
    --cc=barra_cuda@katamail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=maillist@steelskies$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox