From: "Shawn O. Pearce" <spearce@spearce•org>
To: Bert Wesarg <bert.wesarg@googlemail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org, szeder@ira•uka.de
Subject: Re: [PATCH v3] for-each-ref: `:short` format for `refname`
Date: Wed, 3 Sep 2008 08:18:29 -0700 [thread overview]
Message-ID: <20080903151829.GB27682@spearce.org> (raw)
In-Reply-To: <1220431352-30605-1-git-send-email-bert.wesarg@googlemail.com>
Bert Wesarg <bert.wesarg@googlemail•com> wrote:
> Try to shorten the refname to a non-ambiguous name.
>
> Changes in v3:
> * don't compare sha1's, its ambiguous if the short name
> resovles to more than one ref
> * use xstrdup()
> * use indexes for the loops to clarify backward/forward
> direction
>
>
> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail•com>
> Cc: git@vger•kernel.org
> Cc: szeder@ira•uka.de
> Cc: Shawn O. Pearce <spearce@spearce•org>
> ---
Looks good. But the commit messages shouldn't have the "Changes
in v3" section or probably the "Cc:" lines. The changes in v3
part usually goes below the ---.
I don't usually work on for-each-ref, but I'll toss an ack in anyway:
Acked-by: Shawn O. Pearce <spearce@spearce•org>
--
Shawn.
next prev parent reply other threads:[~2008-09-03 15:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7vprnpbqmo.fsf@gitster.siamese.dyndns.org>
2008-08-31 12:41 ` [PATCH] for-each-ref: `:short` format for `refname` Bert Wesarg
2008-09-01 13:15 ` SZEDER Gábor
2008-09-01 14:13 ` Bert Wesarg
2008-09-01 17:52 ` Bert Wesarg
2008-09-01 19:10 ` Shawn O. Pearce
2008-09-01 21:10 ` Bert Wesarg
2008-09-01 21:28 ` Junio C Hamano
2008-09-01 21:44 ` Bert Wesarg
2008-09-02 7:26 ` Bert Wesarg
2008-09-02 14:39 ` Shawn O. Pearce
2008-09-02 21:57 ` [PATCH v2] " Bert Wesarg
2008-09-02 23:10 ` Junio C Hamano
2008-09-03 8:33 ` Bert Wesarg
2008-09-03 8:42 ` [PATCH v3] " Bert Wesarg
2008-09-03 15:18 ` Shawn O. Pearce [this message]
2008-09-03 16:33 ` Bert Wesarg
2008-09-03 16:56 ` Bert Wesarg
2008-09-03 18:36 ` Junio C Hamano
2008-09-05 21:16 ` [PATCH v4] " Bert Wesarg
2008-09-05 22:20 ` Junio C Hamano
2008-09-06 18:16 ` Bert Wesarg
2008-09-08 22:57 ` Junio C Hamano
2008-09-08 23:04 ` Shawn O. Pearce
2008-09-09 6:52 ` Bert Wesarg
2008-09-09 8:05 ` Junio C Hamano
2008-09-09 8:57 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080903151829.GB27682@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=bert.wesarg@googlemail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=szeder@ira$(echo .)uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox