From: "Boyd Stephen Smith Jr." <bss03@volumehost•net>
To: Linus Torvalds <torvalds@linux-foundation•org>
Cc: "R. Tyler Ballance" <tyler@slide•com>,
Johannes Sixt <j.sixt@viscovery•net>,
Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org
Subject: Re: epic fsck SIGSEGV! (was Recovering from epic fail (deleted .git/objects/pack))
Date: Wed, 10 Dec 2008 19:03:53 -0600 [thread overview]
Message-ID: <200812101903.58980.bss03@volumehost.net> (raw)
In-Reply-To: <alpine.LFD.2.00.0812101523570.3340@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]
On Wednesday 2008 December 10 17:40:28 Linus Torvalds wrote:
>On Wed, 10 Dec 2008, R. Tyler Ballance wrote:
>Anyway, that's a really annoying problem, and it's a bug in git.
>
>That stupid fsck commit walker walks the parents recursively.
>
>And judging by the fact that gdb also SIGSEGV's for you when
>doing the backtrace, it looks like the gdb backtrace tracer is _also_
>recursive, and _also_ hits the same issue ;)
>
>So you have definitely found a real bug.
>
>But we should definitely fix this braindamage in fsck. Rather than
>recursively walk the commits, we should add them to a commit list and just
>walk the list iteratively.
Suppose I fixed this tonight. Would you need anything other than a patch
(series) from me? (E.g. copyright assignment or something else legal [vs.
technical])
--
Boyd Stephen Smith Jr. ,= ,-_-. =.
bss03@volumehost•net ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy `-'(. .)`-'
http://iguanasuicide.org/ \_/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-12-11 1:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 0:11 Recovering from epic fail (deleted .git/objects/pack) R. Tyler Ballance
2008-12-10 0:19 ` Junio C Hamano
2008-12-10 10:06 ` R. Tyler Ballance
2008-12-10 11:39 ` Johannes Sixt
2008-12-10 22:52 ` epic fsck SIGSEGV! (was Recovering from epic fail (deleted .git/objects/pack)) R. Tyler Ballance
2008-12-10 23:40 ` Linus Torvalds
2008-12-11 0:24 ` R. Tyler Ballance
2008-12-11 0:45 ` Linus Torvalds
2008-12-11 1:21 ` R. Tyler Ballance
2008-12-11 0:51 ` epic fsck SIGSEGV! Junio C Hamano
2008-12-11 1:03 ` Boyd Stephen Smith Jr. [this message]
2008-12-11 1:16 ` epic fsck SIGSEGV! (was Recovering from epic fail (deleted .git/objects/pack)) Shawn O. Pearce
2008-12-11 1:33 ` Nicolas Pitre
2008-12-11 1:52 ` epic fsck SIGSEGV! Junio C Hamano
2008-12-11 2:16 ` Nicolas Pitre
2008-12-11 3:28 ` epic fsck SIGSEGV! (was Recovering from epic fail (deleted .git/objects/pack)) Linus Torvalds
2008-12-11 3:44 ` Linus Torvalds
2008-12-11 7:33 ` epic fsck SIGSEGV! Junio C Hamano
2008-12-11 17:33 ` Linus Torvalds
2008-12-11 20:18 ` Linus Torvalds
2008-12-11 7:53 ` Junio C Hamano
2008-12-11 4:00 ` epic fsck SIGSEGV! (was Recovering from epic fail (deleted .git/objects/pack)) Boyd Stephen Smith Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812101903.58980.bss03@volumehost.net \
--to=bss03@volumehost$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=j.sixt@viscovery$(echo .)net \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=tyler@slide$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox