From: "Boyd Stephen Smith Jr." <bss03@volumehost•net>
To: git@vger•kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation•org>,
Nicolas Pitre <nico@cam•org>,
"R. Tyler Ballance" <tyler@slide•com>,
Johannes Sixt <j.sixt@viscovery•net>,
Junio C Hamano <gitster@pobox•com>
Subject: Re: epic fsck SIGSEGV! (was Recovering from epic fail (deleted .git/objects/pack))
Date: Wed, 10 Dec 2008 22:00:54 -0600 [thread overview]
Message-ID: <200812102200.59820.bss03@volumehost.net> (raw)
In-Reply-To: <alpine.LFD.2.00.0812101854230.3340@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]
On Wednesday 2008 December 10 21:28:15 Linus Torvalds wrote:
>On Wed, 10 Dec 2008, Nicolas Pitre wrote:
>> http://marc.info/?l=git&m=122889563424786&w=2
>
>Not very pretty. The basic notion is ok, but wouldn't it be nicer to at
>least use a "struct object_array" instead?
As Junio pointed out, we may want to make similar changes with other calls in
fsck_walk with the function itself as a callback. It might even make sense
to have a fsck_walk_full that handles managing the object_array itself.
While we are making changes, there appears to be a copy and paste error from
line 74 to line 76 -- the second "broken link from" should probably be "
to".
I'd have already submitted a patch for that, but I can't figure out how to
tell kmail to not do quoted-printable. :( [And, if I can beat this client
into submission I will.]
Linus, sorry about the reply with no snipping or original content. I
mis-clicked. :(
--
Boyd Stephen Smith Jr. ,= ,-_-. =.
bss03@volumehost•net ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy `-'(. .)`-'
http://iguanasuicide.org/ \_/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2008-12-11 4:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 0:11 Recovering from epic fail (deleted .git/objects/pack) R. Tyler Ballance
2008-12-10 0:19 ` Junio C Hamano
2008-12-10 10:06 ` R. Tyler Ballance
2008-12-10 11:39 ` Johannes Sixt
2008-12-10 22:52 ` epic fsck SIGSEGV! (was Recovering from epic fail (deleted .git/objects/pack)) R. Tyler Ballance
2008-12-10 23:40 ` Linus Torvalds
2008-12-11 0:24 ` R. Tyler Ballance
2008-12-11 0:45 ` Linus Torvalds
2008-12-11 1:21 ` R. Tyler Ballance
2008-12-11 0:51 ` epic fsck SIGSEGV! Junio C Hamano
2008-12-11 1:03 ` epic fsck SIGSEGV! (was Recovering from epic fail (deleted .git/objects/pack)) Boyd Stephen Smith Jr.
2008-12-11 1:16 ` Shawn O. Pearce
2008-12-11 1:33 ` Nicolas Pitre
2008-12-11 1:52 ` epic fsck SIGSEGV! Junio C Hamano
2008-12-11 2:16 ` Nicolas Pitre
2008-12-11 3:28 ` epic fsck SIGSEGV! (was Recovering from epic fail (deleted .git/objects/pack)) Linus Torvalds
2008-12-11 3:44 ` Linus Torvalds
2008-12-11 7:33 ` epic fsck SIGSEGV! Junio C Hamano
2008-12-11 17:33 ` Linus Torvalds
2008-12-11 20:18 ` Linus Torvalds
2008-12-11 7:53 ` Junio C Hamano
2008-12-11 4:00 ` Boyd Stephen Smith Jr. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812102200.59820.bss03@volumehost.net \
--to=bss03@volumehost$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=j.sixt@viscovery$(echo .)net \
--cc=nico@cam$(echo .)org \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=tyler@slide$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox