From: "Shawn O. Pearce" <spearce@spearce•org>
To: Jay Soffian <jaysoffian@gmail•com>
Cc: git@vger•kernel.org, Markus Heidelberg <markus.heidelberg@web•de>,
Sverre Rabbelier <srabbelier@gmail•com>,
Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH 1/3] bash completion: fix completion issues with fetch, pull, and push
Date: Fri, 6 Mar 2009 07:58:14 -0800 [thread overview]
Message-ID: <20090306155814.GG16213@spearce.org> (raw)
In-Reply-To: <07bd381f7984117681504ce57c1f6c40aecafed3.1236314073.git.jaysoffian@gmail.com>
Jay Soffian <jaysoffian@gmail•com> wrote:
> Sverre Rabbelier noticed a completion issue with push:
>
> $ git push ori<tab>
> git push origin
>
> $ git push -f ori<tab>
> git push -f origin/
>
> Markus Heidelberg pointed out that the issue extends to fetch and pull.
>
> The reason is that the current code naively assumes that if
> COMP_CWORD=2, it should complete a remote name, otherwise it should
> complete a refspec. This assumption fails if there are any --options.
>
> This patch fixes that issue by instead scanning COMP_CWORDS to see if
> the remote has been completed yet (we now assume the first non-dashed
> argument is the remote). The new logic is factored into a function,
> shared by fetch, pull, and push.
>
> The new function also properly handles '.' as the remote.
>
> Signed-off-by: Jay Soffian <jaysoffian@gmail•com>
Acked-by: Shawn O. Pearce <spearce@spearce•org>
> ---
> contrib/completion/git-completion.bash | 109 +++++++++++++++++--------------
> 1 files changed, 60 insertions(+), 49 deletions(-)
--
Shawn.
next prev parent reply other threads:[~2009-03-06 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 4:39 [PATCH 0/3] improve bash completion of fetch, pull, and push Jay Soffian
2009-03-06 4:39 ` [PATCH 1/3] bash completion: fix completion issues with " Jay Soffian
2009-03-06 15:58 ` Shawn O. Pearce [this message]
2009-03-11 10:02 ` Nanako Shiraishi
2009-03-11 14:57 ` Jay Soffian
2009-03-06 4:39 ` [PATCH 2/3] bash completion: refactor --strategy completion Jay Soffian
2009-03-06 16:04 ` Shawn O. Pearce
2009-03-06 16:12 ` Jay Soffian
2009-03-06 16:16 ` Shawn O. Pearce
2009-03-06 16:30 ` Jay Soffian
2009-03-06 16:32 ` Shawn O. Pearce
2009-03-06 4:39 ` [PATCH 3/3] bash completion: teach fetch, pull, and push to complete their options Jay Soffian
2009-03-06 16:15 ` Shawn O. Pearce
2009-03-06 6:43 ` [PATCH 0/3] improve bash completion of fetch, pull, and push Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090306155814.GG16213@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jaysoffian@gmail$(echo .)com \
--cc=markus.heidelberg@web$(echo .)de \
--cc=srabbelier@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox