From: "Shawn O. Pearce" <spearce@spearce•org>
To: Jay Soffian <jaysoffian@gmail•com>
Cc: git@vger•kernel.org, Markus Heidelberg <markus.heidelberg@web•de>,
Sverre Rabbelier <srabbelier@gmail•com>,
Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH 2/3] bash completion: refactor --strategy completion
Date: Fri, 6 Mar 2009 08:16:57 -0800 [thread overview]
Message-ID: <20090306161657.GJ16213@spearce.org> (raw)
In-Reply-To: <76718490903060812q2e7b2eefg5f25c9845f678959@mail.gmail.com>
Jay Soffian <jaysoffian@gmail•com> wrote:
> On Fri, Mar 6, 2009 at 11:04 AM, Shawn O. Pearce <spearce@spearce•org> wrote:
> > Jay Soffian <jaysoffian@gmail•com> wrote:
> >> The code to complete --strategy was duplicated between _git_rebase and
> >> _git_merge, and is about to gain a third caller (_git_pull). This patch
> >> factors it into its own function.
> >>
> >> Signed-off-by: Jay Soffian <jaysoffian@gmail•com>
> >
> > Looks OK to me, but I had to squash this in to get it to work.
> > Without this the patch breaks git merge completion entirely:
>
> Weird, I had it completely backwards but it seemed to work. Probably
> because I was sourcing the new completion into my running shell; I'll
> make sure to startup a new shell next time.
>
> With the squash (assuming Junio doesn't mind), is it acked-by you or
> should I resend?
Sorry, yes, with the squash it is Ack'd.
--
Shawn.
next prev parent reply other threads:[~2009-03-06 16:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 4:39 [PATCH 0/3] improve bash completion of fetch, pull, and push Jay Soffian
2009-03-06 4:39 ` [PATCH 1/3] bash completion: fix completion issues with " Jay Soffian
2009-03-06 15:58 ` Shawn O. Pearce
2009-03-11 10:02 ` Nanako Shiraishi
2009-03-11 14:57 ` Jay Soffian
2009-03-06 4:39 ` [PATCH 2/3] bash completion: refactor --strategy completion Jay Soffian
2009-03-06 16:04 ` Shawn O. Pearce
2009-03-06 16:12 ` Jay Soffian
2009-03-06 16:16 ` Shawn O. Pearce [this message]
2009-03-06 16:30 ` Jay Soffian
2009-03-06 16:32 ` Shawn O. Pearce
2009-03-06 4:39 ` [PATCH 3/3] bash completion: teach fetch, pull, and push to complete their options Jay Soffian
2009-03-06 16:15 ` Shawn O. Pearce
2009-03-06 6:43 ` [PATCH 0/3] improve bash completion of fetch, pull, and push Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090306161657.GJ16213@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jaysoffian@gmail$(echo .)com \
--cc=markus.heidelberg@web$(echo .)de \
--cc=srabbelier@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox