* mkstemps compat issue
@ 2009-06-07 12:32 Andreas Färber
2009-06-07 12:49 ` Andreas Färber
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Färber @ 2009-06-07 12:32 UTC (permalink / raw)
To: Git Mailing List; +Cc: Junio C Hamano
Hello,
The merge commit b11cf09043f18b368ec0d988f064ea21247c843d introduced a
git_mkstemps function in path.c, using mkstemps for the
implementation. Unlike mkstemp that function is not part of POSIX, so
we seem to need a NO_MKSTEMPS option and corresponding alternative
code path.
Any suggestions how to best replace mkstemps?
Thanks,
Andreas
[Please keep me cc'ed.]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mkstemps compat issue
2009-06-07 12:32 mkstemps compat issue Andreas Färber
@ 2009-06-07 12:49 ` Andreas Färber
2009-06-08 1:13 ` David Aguilar
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Färber @ 2009-06-07 12:49 UTC (permalink / raw)
To: Git Mailing List; +Cc: Junio C Hamano, HaikuPorts developers discussion list
Am 07.06.2009 um 14:32 schrieb Andreas Färber:
> The merge commit b11cf09043f18b368ec0d988f064ea21247c843d introduced
> a git_mkstemps function in path.c, using mkstemps for the
> implementation. Unlike mkstemp that function is not part of POSIX,
> so we seem to need a NO_MKSTEMPS option and corresponding
> alternative code path.
>
> Any suggestions how to best replace mkstemps?
Sorry for the noise... NO_MKSTEMPS=YesPlease does work correctly if
typed correctly. (Thanks for the hint!)
It was a little confusing seeing mkstemps being used unconditionally
in path.c, but it's being #defined in git-compat-util.h, so everything
is fine.
Regards,
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mkstemps compat issue
2009-06-07 12:49 ` Andreas Färber
@ 2009-06-08 1:13 ` David Aguilar
0 siblings, 0 replies; 3+ messages in thread
From: David Aguilar @ 2009-06-08 1:13 UTC (permalink / raw)
To: Andreas Färber
Cc: Git Mailing List, Junio C Hamano,
HaikuPorts developers discussion list
On Sun, Jun 07, 2009 at 02:49:16PM +0200, Andreas Färber wrote:
>
> Am 07.06.2009 um 14:32 schrieb Andreas Färber:
>
>> The merge commit b11cf09043f18b368ec0d988f064ea21247c843d introduced a
>> git_mkstemps function in path.c, using mkstemps for the
>> implementation. Unlike mkstemp that function is not part of POSIX, so
>> we seem to need a NO_MKSTEMPS option and corresponding alternative code
>> path.
>>
>> Any suggestions how to best replace mkstemps?
>
> Sorry for the noise... NO_MKSTEMPS=YesPlease does work correctly if
> typed correctly. (Thanks for the hint!)
Thanks for keeping an eye on it.
I'm still keeping my eye on the patch that introduced the
basename() compat function to see if we missed any Makefile
settings for the non-linux platforms. We support a lot of
platforms! =)
--
David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-08 1:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-07 12:32 mkstemps compat issue Andreas Färber
2009-06-07 12:49 ` Andreas Färber
2009-06-08 1:13 ` David Aguilar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox