From: Daniel Convissor <danielc@analysisandsolutions•com>
To: Git Mailing List <git@vger•kernel.org>
Subject: Re: hitting home directory's parent
Date: Sun, 23 Aug 2009 01:12:44 -0400 [thread overview]
Message-ID: <20090823051244.GB10761@panix.com> (raw)
In-Reply-To: <20090822181607.GA25823@coredump.intra.peff.net>
Hi Jeff:
On Sat, Aug 22, 2009 at 02:16:07PM -0400, Jeff King wrote:
>
> Without looking, I would not be surprised if it is a side effect of
> git trying to look up help-related config.
That explains what's happening. cmd_help() calls git_config(). Though
it seems it would be more, uh, helpful, if help produced basic usage
output no matter what, and then produce the more detailed config based
output if possible.
> Probably it is calling "setup_git_directory_gently" and ignoring an
> error return, but there is a die() inside that function. The bug
> then is that the _gently form is calling die().
Yep. setup.c, lines 391 and 392 (master branch):
if (chdir(".."))
die_errno("Cannot change to '%s/..'", cwd);
> As for fixing the setup code, I am sadly way behind on my git queue and
> not likely to catch up to this anytime soon. So if anybody feels like
> taking a stab at it, that would be very welcome.
Is there a bug tracker y'all use where I can enter a ticket?
Thanks,
--Dan
--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409
next prev parent reply other threads:[~2009-08-23 5:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 20:05 hitting home directory's parent Daniel Convissor
2009-08-22 4:10 ` Nguyen Thai Ngoc Duy
2009-08-22 15:05 ` Daniel Convissor
2009-08-22 16:20 ` Nguyen Thai Ngoc Duy
2009-08-22 16:22 ` Nguyen Thai Ngoc Duy
2009-08-22 18:16 ` Jeff King
2009-08-23 4:07 ` Nguyen Thai Ngoc Duy
2009-08-25 4:42 ` Jeff King
2009-08-23 5:12 ` Daniel Convissor [this message]
2009-08-25 4:48 ` Jeff King
2009-08-23 4:42 ` Daniel Convissor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090823051244.GB10761@panix.com \
--to=danielc@analysisandsolutions$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox