From: "Shawn O. Pearce" <spearce@spearce•org>
To: Tarmigan Casebolt <tarmigan+git@gmail•com>,
Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 1/2] http-backend: Fix access beyond end of string.
Date: Sun, 15 Nov 2009 17:36:54 -0800 [thread overview]
Message-ID: <20091116013654.GX11919@spearce.org> (raw)
In-Reply-To: <1258233058-2348-1-git-send-email-tarmigan+git@gmail.com>
Tarmigan Casebolt <tarmigan+git@gmail•com> wrote:
> diff --git a/http-backend.c b/http-backend.c
> index f8ea9d7..ab9433d 100644
> --- a/http-backend.c
> +++ b/http-backend.c
> @@ -634,7 +634,7 @@ int main(int argc, char **argv)
> cmd = c;
> cmd_arg = xmalloc(n);
> strncpy(cmd_arg, dir + out[0].rm_so + 1, n);
> - cmd_arg[n] = '\0';
> + cmd_arg[n-1] = '\0';
> dir[out[0].rm_so] = 0;
> break;
Shouldn't this instead be:
diff --git a/http-backend.c b/http-backend.c
index 9021266..16ec635 100644
--- a/http-backend.c
+++ b/http-backend.c
@@ -626,7 +626,7 @@ int main(int argc, char **argv)
}
cmd = c;
- cmd_arg = xmalloc(n);
+ cmd_arg = xmalloc(n + 1);
strncpy(cmd_arg, dir + out[0].rm_so + 1, n);
cmd_arg[n] = '\0';
dir[out[0].rm_so] = 0;
The cmd_arg string was simply allocated too small. Your fix is
terminating the string one character too short which would cause
get_loose_object and get_pack_file to break.
--
Shawn.
next prev parent reply other threads:[~2009-11-16 1:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 21:10 [PATCH 1/2] http-backend: Fix access beyond end of string Tarmigan Casebolt
2009-11-14 21:10 ` [PATCH 2/2] http-backend: Let gcc check the format of more printf-type functions Tarmigan Casebolt
2009-11-16 1:39 ` Shawn O. Pearce
2009-11-16 1:36 ` Shawn O. Pearce [this message]
2009-11-16 4:55 ` [PATCH 1/2] http-backend: Fix access beyond end of string Jeff King
2009-11-16 6:12 ` Junio C Hamano
2009-11-17 4:46 ` Tarmigan
2009-11-23 17:20 ` Brian Gernhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116013654.GX11919@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=tarmigan+git@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox