From: "Shawn O. Pearce" <spearce@spearce•org>
To: Tarmigan Casebolt <tarmigan+git@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 2/2] http-backend: Let gcc check the format of more printf-type functions.
Date: Sun, 15 Nov 2009 17:39:11 -0800 [thread overview]
Message-ID: <20091116013911.GY11919@spearce.org> (raw)
In-Reply-To: <1258233058-2348-2-git-send-email-tarmigan+git@gmail.com>
Tarmigan Casebolt <tarmigan+git@gmail•com> wrote:
> We already have these checks in many printf-type functions that have
> prototypes which are in header files. Add these same checks to
> static functions in http-backend.c
>
> Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail•com>
> ---
>
> Shawn, please consider this patch in addition to the one that you posted
> that actually fixes the bug. With this patch, gcc will warn about that bug.
Yup, it would have caught it, thanks.
Acked-by: Shawn O. Pearce <spearce@spearce•org>
--
Shawn.
next prev parent reply other threads:[~2009-11-16 1:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 21:10 [PATCH 1/2] http-backend: Fix access beyond end of string Tarmigan Casebolt
2009-11-14 21:10 ` [PATCH 2/2] http-backend: Let gcc check the format of more printf-type functions Tarmigan Casebolt
2009-11-16 1:39 ` Shawn O. Pearce [this message]
2009-11-16 1:36 ` [PATCH 1/2] http-backend: Fix access beyond end of string Shawn O. Pearce
2009-11-16 4:55 ` Jeff King
2009-11-16 6:12 ` Junio C Hamano
2009-11-17 4:46 ` Tarmigan
2009-11-23 17:20 ` Brian Gernhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116013911.GY11919@spearce.org \
--to=spearce@spearce$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=tarmigan+git@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox