From: Markus Heidelberg <markus.heidelberg@web•de>
To: David Aguilar <davvid@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
Paul Mackerras <paulus@samba•org>,
peff@peff•net, sam@vilain•net, git@vger•kernel.org
Subject: Re: [PATCH] gitk: Use git-difftool for external diffs
Date: Sat, 21 Nov 2009 00:33:42 +0100 [thread overview]
Message-ID: <200911210033.42661.markus.heidelberg@web.de> (raw)
In-Reply-To: <20091120185522.GC56351@gmail.com>
David Aguilar, 2009-11-20:
> The argument in favor of difftool is one of user
> expectations. From a user's POV it ~seems~ desirable for
> gitk to honor difftool configurations.
In general I absolutely like the idea. There are however problems you
can encounter.
I use vimdiff for git-difftool and gvimdiff for gitk. When testing gitk
with your patch, I wondered where the editor is, because nothing popped
up. I then found vim on the terminal from where I started gitk. Even
worse: when started with "gitk &", the vim process runs somewhere in the
background and gitk freezes.
To overcome this problem maybe we need a second config variable like
diff.guitool.
Markus
next prev parent reply other threads:[~2009-11-20 23:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 3:12 [PATCH] gitk: Use git-difftool for external diffs David Aguilar
2009-11-19 9:03 ` Paul Mackerras
2009-11-19 19:39 ` David Aguilar
2009-11-19 22:21 ` Paul Mackerras
2009-11-20 7:53 ` Junio C Hamano
2009-11-20 18:55 ` David Aguilar
2009-11-20 20:51 ` Junio C Hamano
2009-11-21 21:47 ` David Aguilar
2009-11-20 23:33 ` Markus Heidelberg [this message]
2009-12-30 3:13 ` Nanako Shiraishi
2009-12-30 7:49 ` Junio C Hamano
2009-12-31 7:16 ` David Aguilar
2009-12-31 20:37 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2010-03-27 21:45 David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911210033.42661.markus.heidelberg@web.de \
--to=markus.heidelberg@web$(echo .)de \
--cc=davvid@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=peff@peff$(echo .)net \
--cc=sam@vilain$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox