From: Junio C Hamano <gitster@pobox•com>
To: Paul Mackerras <paulus@samba•org>
Cc: David Aguilar <davvid@gmail•com>,
peff@peff•net, sam@vilain•net, git@vger•kernel.org
Subject: Re: [PATCH] gitk: Use git-difftool for external diffs
Date: Thu, 19 Nov 2009 23:53:37 -0800 [thread overview]
Message-ID: <7vhbsp7htq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <19205.50406.91209.309984@cargo.ozlabs.ibm.com> (Paul Mackerras's message of "Fri\, 20 Nov 2009 09\:21\:26 +1100")
Paul Mackerras <paulus@samba•org> writes:
> I have no problem with using git difftool if the underlying git is new
> enough, I just don't want gitk to explode when it isn't.
I somehow doubt there are many users who use pre 1.6.3 git but keep their
gitk separately updated to very recent version, so personally I wouldn't
worry too much about this.
> Also, I don't think we should remove the ability for the user to
> choose which external diff tool to use.
This is a larger concern. Does "difftool" allow use of an arbitrary tool
like how gitk does (I have a suspicion that it is not as flexible)?
next prev parent reply other threads:[~2009-11-20 7:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 3:12 [PATCH] gitk: Use git-difftool for external diffs David Aguilar
2009-11-19 9:03 ` Paul Mackerras
2009-11-19 19:39 ` David Aguilar
2009-11-19 22:21 ` Paul Mackerras
2009-11-20 7:53 ` Junio C Hamano [this message]
2009-11-20 18:55 ` David Aguilar
2009-11-20 20:51 ` Junio C Hamano
2009-11-21 21:47 ` David Aguilar
2009-11-20 23:33 ` Markus Heidelberg
2009-12-30 3:13 ` Nanako Shiraishi
2009-12-30 7:49 ` Junio C Hamano
2009-12-31 7:16 ` David Aguilar
2009-12-31 20:37 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2010-03-27 21:45 David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhbsp7htq.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=davvid@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
--cc=peff@peff$(echo .)net \
--cc=sam@vilain$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox