public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Lars Damerow <lars@pixar•com>
To: Sverre Rabbelier <srabbelier@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Add support for GIT_ONE_FILESYSTEM
Date: Mon, 15 Mar 2010 16:36:45 -0700	[thread overview]
Message-ID: <20100315233645.GG11157@pixar.com> (raw)
In-Reply-To: <fabb9a1e1003151616m4c0e9100g77170433f6a67912@mail.gmail.com>

>From Sverre Rabbelier <srabbelier@gmail•com>, Tue, Mar 16, 2010 at 12:16:19AM +0100:
> Heya,
> 
> On Mon, Mar 15, 2010 at 22:40, Lars Damerow <lars@pixar•com> wrote:
> > if (buf.st_dev != current_device)
> >     die("refusing to cross filesystem boundary '%s/..'", cwd);
> 
> Great, that's going to tell the unfortunate user who runs into this a
> whole lot of nothing. Shouldn't you at least tell them what git was
> trying to do, how they can fix it if this is not the desired behavior,
> etc. etc.?

Hi Sverre,

You're right, that's a badly-worded error. How about this?

    Not a git repository (or any parent up to /path/to/mountpoint)
    Stopping at filesystem boundary since GIT_ONE_FILESYSTEM is set.

-lars

--
lars r. damerow :: button pusher :: pixar animation studios

Science Factoid:  The common cockroach shares 99.5 percent of its DNA code
                  with e-mail spammers and telemarketers.

  reply	other threads:[~2010-03-15 23:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-15 21:40 [PATCH] Add support for GIT_ONE_FILESYSTEM Lars Damerow
2010-03-15 23:16 ` Sverre Rabbelier
2010-03-15 23:36   ` Lars Damerow [this message]
2010-03-16  2:33 ` Jeff King
2010-03-16  3:28   ` Lars Damerow
2010-03-16  3:37     ` Jeff King
2010-03-16  4:19   ` Junio C Hamano
2010-03-16  5:56     ` Lars Damerow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100315233645.GG11157@pixar.com \
    --to=lars@pixar$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=srabbelier@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox