From: Eric Wong <normalperson@yhbt•net>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail•com>
Cc: git@vger•kernel.org, jnareb@gmail•com, chriscool@tuxfamily•org,
pasky@ucw•cz
Subject: Re: [PATCHv3 GSoC] git-instaweb: Configure it to work with new gitweb structure
Date: Sun, 23 May 2010 09:56:45 +0000 [thread overview]
Message-ID: <20100523095645.GD3426@dcvr.yhbt.net> (raw)
In-Reply-To: <1274599968-3749-1-git-send-email-pavan.sss1991@gmail.com>
Pavan Kumar Sunkara <pavan.sss1991@gmail•com> wrote:
> While at it, change apache2 configuration to use the same access log
> and error log files as the rest of web servers supported by
> git-instaweb.
Hi Pavan, I'm late to this thread, but I'm leaning against forcing
access logs onto people. I don't believe access logs are necessary for
instaweb. Error logs are important for debugging breakage, yes, but
access logs aren't worth the trouble IMHO.
Also, using the same error log paths might make it confusing to people
switching between web servers. In fact, it may be the most confusing
for those folks if they're trying different web servers and forgetting
to shut down the previous server before starting the next. They could
end up seeing confusing log messages from the wrong server if they
look in the error log to debug the problem.
I'm not sure why Mongoose has access logs enabled by default, but I know
I conciously left it out by default for lighttpd/apache/webrick.
--
Eric Wong
next prev parent reply other threads:[~2010-05-23 9:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 7:32 [PATCHv3 GSoC] git-instaweb: Configure it to work with new gitweb structure Pavan Kumar Sunkara
2010-05-23 9:54 ` Jakub Narebski
2010-05-23 9:56 ` Eric Wong [this message]
2010-05-23 10:18 ` Pavan Kumar Sunkara
2010-05-24 9:55 ` Christian Couder
2010-05-24 15:14 ` Pavan Kumar Sunkara
2010-05-25 1:34 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100523095645.GD3426@dcvr.yhbt.net \
--to=normalperson@yhbt$(echo .)net \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
--cc=pasky@ucw$(echo .)cz \
--cc=pavan.sss1991@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox