From: Yann Dirson <ydirson@free•fr>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: Thiago Farina <tfransosi@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH] Sync "git diff -h" with the manual, show options summary.
Date: Sat, 23 Oct 2010 20:44:25 +0200 [thread overview]
Message-ID: <20101023184425.GP4983@home.lan> (raw)
In-Reply-To: <vpqvd4sn5ud.fsf@bauges.imag.fr>
On Sat, Oct 23, 2010 at 08:04:26PM +0200, Matthieu Moy wrote:
> Thiago Farina <tfransosi@gmail•com> writes:
>
> > On Sat, Oct 23, 2010 at 11:33 AM, Yann Dirson <ydirson@altern•org> wrote:
> >> static const char builtin_diff_usage[] =
> >> -"git diff <options> <rev>{0,2} -- <path>*";
> >> +"git diff [<common diff options>] <commit>{0,2} -- <path>*"
> >
> > Why change from <options> to <common diff options> ?
>
> Because this is what the man page says I guess.
Yes, as well as the usage strings for diff-tree, diff-files, and
diff-index. "diff" was just the only one to be different here, and if
we want to keep "<options>" for conciseness here, we also probably
want to change it everywhere (or maybe "<diff options>" for the diff-*
commands ?) - after all, this is just a short usage string, not the
reference page.
next prev parent reply other threads:[~2010-10-23 18:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 13:33 [PATCH] Sync "git diff -h" with the manual, show options summary Yann Dirson
2010-10-23 14:07 ` Yann Dirson
2010-10-23 18:02 ` Thiago Farina
2010-10-23 18:04 ` Matthieu Moy
2010-10-23 18:44 ` Yann Dirson [this message]
2010-10-24 15:15 ` Štěpán Němec
-- strict thread matches above, loose matches on Subject: below --
2010-10-01 7:32 Yann Dirson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101023184425.GP4983@home.lan \
--to=ydirson@free$(echo .)fr \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=tfransosi@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox