From: Eric Wong <normalperson@yhbt•net>
To: Robert Luberda <robert@debian•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id
Date: Wed, 1 Aug 2012 14:43:18 -0700 [thread overview]
Message-ID: <20120801214318.GA10384@dcvr.yhbt.net> (raw)
In-Reply-To: <1343856197-6393-1-git-send-email-robert@debian.org>
Robert Luberda <robert@debian•org> wrote:
> While importing changes from SVN by `git svn fetch' strip any
> white spaces from beginnings and endings of SVN commit messages
> and skip adding a new line character before `git-svn-id:'
> line in case the commit message ends with another pseudo-header
> (like From:, Signed-off-by: or Change-Id:, etc.).
>
> This patch allows one to use gerrit code review system on git-svn-managed
> repositories. gerrit expects its `Change-Id:' header to appear in the
> last paragraph of commit message and `git-svn-id:' following a new
> line character was breaking this expectation.
I've long wanted to change this, but it breaks compatibility if folks
are importing from the same repo, sharing changes and one upgrades
git-svn.
How about making this optional and configurable at init/clone time?
next prev parent reply other threads:[~2012-08-01 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 21:23 [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id Robert Luberda
2012-08-01 21:43 ` Eric Wong [this message]
2012-08-01 22:27 ` Robert Luberda
2012-08-01 23:01 ` Eric Wong
2012-08-19 21:46 ` Robert Luberda
2012-08-19 21:52 ` [PATCH/RFC] git svn: optionally trim imported log messages Robert Luberda
2012-08-19 23:59 ` Junio C Hamano
2012-08-24 22:38 ` Robert Luberda
2012-08-24 23:38 ` Junio C Hamano
2012-08-21 21:45 ` [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id Eric Wong
2012-08-21 22:35 ` Junio C Hamano
2012-08-24 23:14 ` Robert Luberda
2012-08-26 0:36 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801214318.GA10384@dcvr.yhbt.net \
--to=normalperson@yhbt$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=robert@debian$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox